From 4ddc2bb7664156a1cad9d47b24a7e874713cbc52 Mon Sep 17 00:00:00 2001 From: Lubomir Rintel Date: Sat, 16 Mar 2019 14:58:20 +0100 Subject: [PATCH 1/2] clients: do not require gsm.apn The server doesn't require it either. --- clients/common/nm-meta-setting-desc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/clients/common/nm-meta-setting-desc.c b/clients/common/nm-meta-setting-desc.c index ef8574a174..d509b7a7e9 100644 --- a/clients/common/nm-meta-setting-desc.c +++ b/clients/common/nm-meta-setting-desc.c @@ -5425,7 +5425,6 @@ static const NMMetaPropertyInfo *const property_infos_GSM[] = { PROPERTY_INFO_WITH_DESC (NM_SETTING_GSM_APN, .is_cli_option = TRUE, .property_alias = "apn", - .inf_flags = NM_META_PROPERTY_INF_FLAG_REQD, .prompt = N_("APN"), .property_type = &_pt_gobject_string, ), From 5354fe4e7f6c65966a64ef1c6794307d93efbe31 Mon Sep 17 00:00:00 2001 From: Lubomir Rintel Date: Mon, 18 Mar 2019 15:30:34 +0100 Subject: [PATCH 2/2] wwan/modem-broadband: no point in insisting on pre-existing GSM setting We can just create a default one upon connection completion. --- src/devices/wwan/nm-modem-broadband.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/src/devices/wwan/nm-modem-broadband.c b/src/devices/wwan/nm-modem-broadband.c index 1cb549b017..ffdc61a6b7 100644 --- a/src/devices/wwan/nm-modem-broadband.c +++ b/src/devices/wwan/nm-modem-broadband.c @@ -679,19 +679,6 @@ complete_connection (NMModem *_self, } if (MODEM_CAPS_3GPP (modem_caps)) { - NMSettingGsm *s_gsm; - - s_gsm = nm_connection_get_setting_gsm (connection); - if (!s_gsm) { - /* Need a GSM setting at least */ - g_set_error_literal (error, - NM_CONNECTION_ERROR, - NM_CONNECTION_ERROR_MISSING_SETTING, - _("GSM mobile broadband connection requires a 'gsm' setting")); - g_prefix_error (error, "%s: ", NM_SETTING_GSM_SETTING_NAME); - return FALSE; - } - nm_utils_complete_generic (NM_PLATFORM_GET, connection, NM_SETTING_GSM_SETTING_NAME,