system/NetworkManager
system/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager synced 2024-10-01 13:55:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

platform/netlink: use nm_random_get_bytes() for initial seq value

Browse source 
Coverity warns when a time_t is cast to 32-bits -- however, we do not
need to use the time here at all, since it is only used as an initializing value
that is not expected to be a timestamp, and we can use random bytes instead.

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1904
This commit is contained in:
Jan Vaclav 2024-03-27 11:51:00 +01:00
parent e42ef92bfa
commit 886146b5b1
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/libnm-platform/nm-netlink.c
View file

@ -4,6 +4,7 @@
*/
#include "libnm-glib-aux/nm-default-glib-i18n-lib.h"
#include "libnm-glib-aux/nm-random-utils.h"
#include "nm-netlink.h"
@ -1105,7 +1106,7 @@ nl_socket_new(struct nl_sock **out_sk,
{
nm_auto_nlsock struct nl_sock *sk = NULL;
nm_auto_close int fd = -1;
time_t t;
unsigned seq_init;
int err;
int nmerr;
socklen_t addrlen;
@ -1121,7 +1122,7 @@ nl_socket_new(struct nl_sock **out_sk,
if (fd < 0)
return -nm_errno_from_native(errno);
t = time(NULL);
nm_random_get_bytes(&seq_init, sizeof(seq_init));
sk = g_slice_new(struct nl_sock);
*sk = (struct nl_sock){
@ -1138,8 +1139,8 @@ nl_socket_new(struct nl_sock **out_sk,
.nl_family = AF_NETLINK,
.nl_groups = 0,
},
.s_seq_expect = t,
.s_seq_next = t,
.s_seq_expect = seq_init,
.s_seq_next = seq_init,
.s_bufsize = 0,
.s_msg_peek = !NM_FLAGS_HAS(flags, NL_SOCKET_FLAGS_DISABLE_MSG_PEEK),
.s_auto_ack = TRUE,