system/NetworkManager
system/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager synced 2024-10-06 16:21:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

dispatcher: remove trailing dot from error messages

Browse source 
The error messages are logged by the dispatcher and passed back to
NetworkManager which also logs them. NetworkManager log messages
usually don't end with a dot: remove it.
This commit is contained in:
Beniamino Galvani 2024-02-12 09:55:29 +01:00
parent 433e9a84f7
commit 7b769e9e49
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/nm-dispatcher/nm-dispatcher.c
View file

@ -412,7 +412,7 @@ script_watch_cb(GPid pid, int status, gpointer user_data)
script->result = DISPATCH_RESULT_SUCCESS;
} else {
status_desc = nm_utils_get_process_exit_status_desc(status);
script->error = g_strdup_printf("Script '%s' %s.", script->script, status_desc);
script->error = g_strdup_printf("Script '%s' %s", script->script, status_desc);
}
if (script->result == DISPATCH_RESULT_SUCCESS) {
@ -447,7 +447,7 @@ again:
goto again;
}
script->error = g_strdup_printf("Script '%s' timed out.", script->script);
script->error = g_strdup_printf("Script '%s' timed out", script->script);
script->result = DISPATCH_RESULT_TIMEOUT;
g_spawn_close_pid(script->pid);
@ -466,19 +466,19 @@ check_permissions(struct stat *s, const char **out_error_msg)
/* Only accept files owned by root */
if (s->st_uid != 0) {
*out_error_msg = "not owned by root.";
*out_error_msg = "not owned by root";
return FALSE;
}
/* Only accept files not writable by group or other, and not SUID */
if (s->st_mode & (S_IWGRP | S_IWOTH | S_ISUID)) {
*out_error_msg = "writable by group or other, or set-UID.";
*out_error_msg = "writable by group or other, or set-UID";
return FALSE;
}
/* Only accept files executable by the owner */
if (!(s->st_mode & S_IXUSR)) {
*out_error_msg = "not executable by owner.";
*out_error_msg = "not executable by owner";
return FALSE;
}