system/NetworkManager
system/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager synced 2024-10-14 20:18:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove assertion for empty DHCP options

Browse source 
It turns out that some routers return responses to DHCP6
Information-request messages that do not contain any of the options
that we insert in the "options" table. When that happened and the
info-only flag for DHCP6 was set, the assertion was triggered and
NetworkManager crashed. We remove the assertion as having empty options
is a possibility and is harmless anyway. This happened while using the
internal dhclient.
This commit is contained in:
Alfonso Sánchez-Beato 2017-03-27 17:18:36 +02:00 committed by Lubomir Rintel
parent 1db6c80cee
commit 76cf0e590f
1 changed files with 0 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/dhcp/nm-dhcp-client.c
View file

@ -298,7 +298,6 @@ nm_dhcp_client_set_state (NMDhcpClient *self,
g_assert ( (priv->ipv6 && NM_IS_IP6_CONFIG (ip_config))
|| (!priv->ipv6 && NM_IS_IP4_CONFIG (ip_config)));
g_assert (options);
g_assert_cmpint (g_hash_table_size (options), >, 0);
} else {
g_assert (ip_config == NULL);
g_assert (options == NULL);