system/NetworkManager
system/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager synced 2024-07-22 10:46:59 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

nmcli: fix return code on "nmcli device connect" error

Browse source 
Before:
  $ nmcli device connect veth0; echo $?
  Error: Connection activation failed: (5) IP configuration could not be reserved (no available address, timeout, etc.).
  0

After
  $ nmcli device connect veth0; echo $?
  Error: Connection activation failed: (5) IP configuration could not be reserved (no available address, timeout, etc.).
  4

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/902
This commit is contained in:
Beniamino Galvani 2022-10-03 13:46:02 +02:00
parent 88f5e7518a
commit 5cf9395b94
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/nmcli/devices.c
View file

@ -2132,9 +2132,11 @@ connected_state_cb(AddAndActivateInfo *info)
_("Hint: \"nmcli dev wifi show-password\" shows the Wi-Fi name and password.\n"));
} else if (state <= NM_DEVICE_STATE_DISCONNECTED || state >= NM_DEVICE_STATE_DEACTIVATING) {
reason = nm_device_get_state_reason(info->device);
g_print(_("Error: Connection activation failed: (%d) %s.\n"),
reason,
gettext(nmc_device_reason_to_string(reason)));
g_string_printf(info->nmc->return_text,
_("Error: Connection activation failed: (%d) %s."),
reason,
gettext(nmc_device_reason_to_string(reason)));
info->nmc->return_value = NMC_RESULT_ERROR_CON_ACTIVATION;
} else {
return;
}