system/NetworkManager
system/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager synced 2024-07-22 18:54:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

wwan: update default connection timeout to 200s

Browse source 
The following merge request in ModemManager introduces a more or less
common timeout value for the connection attempts in all plugin and
protocol implementations:

  https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/391

The value chosen by default for the steps that may take long to
complete in a connection attempt is 180s, and 120s for the steps in
the disconnection path.

Until now, every different plugin or protocol had a different timeout
value, all of them <= 180s, and with that change in ModemManager, the
values are now aligned for all.

Note, though, that this does not mean that a connection attempt will
take always less than 180s, as there may be multiple other steps in
addition to the one that took the maximum timeout. The value chosen
for NetworkManager is a compromise between the new defaults from MM
and what the user would expect under e.g. very low quality conditions.

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/678
This commit is contained in:
Aleksander Morgado 2020-11-12 18:38:59 +01:00 committed by Thomas Haller
parent c1ff06e119
commit 5b7ce438d9
No known key found for this signature in database
GPG key ID: 29C2366E4DFC5728
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/devices/wwan/nm-modem-broadband.c
View file

@ -39,8 +39,11 @@ MODEM_CAPS_3GPP(MMModemCapability caps)
#define MODEM_CAPS_3GPP2(caps) (caps & (MM_MODEM_CAPABILITY_CDMA_EVDO))
/* Maximum time to keep the DBus call waiting for a connection result */
#define MODEM_CONNECT_TIMEOUT_SECS 120
/* Maximum time to keep the DBus call waiting for a connection result.
* This value is greater than the default timeout in ModemManager (180s since
* 1.16), so that whenever possible the timeout happens first there instead of
* in NetworkManager. */
#define MODEM_CONNECT_TIMEOUT_SECS 200
/*****************************************************************************/