system/NetworkManager
system/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager synced 2024-07-23 19:24:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

clients: fix memory leak when parsing routes

Browse source 
The new hash table should destroy elements stolen from the hash table
returned by nm_utils_parse_variant_attributes().

Fixes: d094914120
This commit is contained in:
Beniamino Galvani 2018-06-27 09:57:41 +02:00 committed by Thomas Haller
parent e645aeb12c
commit 31bda1b837
1 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
clients/common/nm-meta-setting-desc.c
View file

@ -192,11 +192,20 @@ _parse_ip_route (int family,
return NULL;
}
if (!attrs)
attrs = g_hash_table_new (nm_str_hash, g_str_equal);
if (!attrs) {
attrs = g_hash_table_new_full (nm_str_hash,
g_str_equal,
g_free,
(GDestroyNotify) g_variant_unref);
}
g_hash_table_iter_init (&iter, tmp_attrs);
while (g_hash_table_iter_next (&iter, (gpointer *) &iter_key, (gpointer *) &iter_value)) {
/* need to sink the reference, because nm_utils_parse_variant_attributes() returns
* floating refs. */
g_variant_ref_sink (iter_value);
if (!nm_ip_route_attribute_validate (iter_key, iter_value, family, NULL, error)) {
g_prefix_error (error, "%s: ", iter_key);
g_hash_table_unref (tmp_attrs);