From 2b449694e550dd16d8f094779d307ce725316a66 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Fri, 7 Jan 2022 07:30:43 +0100 Subject: [PATCH] checkpatch: complain about tabs in source file There are very few places left where we would accept tabs in a source file. Warn about that, even if it might cause some false positives. I think this line was commented out due to a mistake. --- contrib/scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/scripts/checkpatch.pl b/contrib/scripts/checkpatch.pl index 57460522b8..733a42d7b0 100755 --- a/contrib/scripts/checkpatch.pl +++ b/contrib/scripts/checkpatch.pl @@ -198,7 +198,7 @@ complain ("Don't use API that uses the numeric source id. Instead, use GSource a complain ("Prefer g_snprintf() over snprintf() (for consistency)") if $line =~ /\b(snprintf)\b/; complain ("Avoid g_clear_pointer() and use nm_clear_pointer() (or nm_clear_g_free(), g_clear_object(), etc.)") if $line =~ /\b(g_clear_pointer)\b/; complain ("Define setting properties with _nm_setting_property_define_direct_*() API") if $line =~ /g_param_spec_/ and $filename =~ /\/libnm-core-impl\/nm-setting/; -#complain ("Use spaces instead of tabs") if $line =~ /\t/; +complain ("Use spaces instead of tabs") if $line =~ /\t/; # Further on we process stuff without comments. $_ = $line;