system/NetworkManager
system/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager synced 2024-07-22 10:46:59 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

shared/compat: add compat for nm_setting_vpn_get_data_keys() and nm_setting_vpn_get_secret_keys()

Browse source
This commit is contained in:
Thomas Haller 2017-11-20 19:41:45 +01:00
parent 1cb147663b
commit 272439cb20
3 changed files with 91 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Makefile.am
View file

@ -670,7 +670,6 @@ libnm_core_tests_test_setting_dcb_CPPFLAGS = $(libnm_core_tests_cppflags)
libnm_core_tests_test_settings_defaults_CPPFLAGS = $(libnm_core_tests_cppflags)
libnm_core_tests_test_general_SOURCES = \
shared/nm-utils/nm-compat.c \
libnm-core/tests/test-general-enums.h \
libnm-core/tests/test-general.c
@ -1067,6 +1066,7 @@ libnm_tests_test_remote_settings_client_CPPFLAGS = $(libnm_tests_cppflags)
libnm_tests_test_secret_agent_CPPFLAGS = $(libnm_tests_cppflags)
libnm_tests_test_general_SOURCES = \
shared/nm-utils/nm-compat.c \
libnm/tests/test-general.c
libnm_tests_test_nm_client_SOURCES = \

63
shared/nm-utils/nm-compat.c
View file

@ -23,3 +23,66 @@
#include "nm-compat.h"
/*****************************************************************************/
static void
_get_keys_cb (const char *key, const char *val, gpointer user_data)
{
GPtrArray *a = user_data;
g_ptr_array_add (a, g_strdup (key));
}
static const char **
_get_keys (NMSettingVpn *setting,
gboolean is_secrets,
guint *out_length)
{
guint len;
const char **keys = NULL;
gs_unref_ptrarray GPtrArray *a = NULL;
nm_assert (NM_IS_SETTING_VPN (setting));
a = g_ptr_array_new ();
if (is_secrets)
nm_setting_vpn_foreach_secret (setting, _get_keys_cb, a);
else
nm_setting_vpn_foreach_data_item (setting, _get_keys_cb, a);
len = a->len;
if (a->len) {
g_ptr_array_sort (a, nm_strcmp_p);
g_ptr_array_add (a, NULL);
keys = (const char **) g_ptr_array_free (g_steal_pointer (&a), FALSE);
/* we need to cache the keys *somewhere*. */
g_object_set_qdata_full (G_OBJECT (setting),
is_secrets
? NM_CACHED_QUARK ("libnm._nm_setting_vpn_get_secret_keys")
: NM_CACHED_QUARK ("libnm._nm_setting_vpn_get_data_keys"),
keys,
(GDestroyNotify) g_strfreev);
}
NM_SET_OUT (out_length, len);
return keys;
}
const char **
_nm_setting_vpn_get_data_keys (NMSettingVpn *setting,
guint *out_length)
{
g_return_val_if_fail (NM_IS_SETTING_VPN (setting), NULL);
return _get_keys (setting, FALSE, out_length);
}
const char **
_nm_setting_vpn_get_secret_keys (NMSettingVpn *setting,
guint *out_length)
{
g_return_val_if_fail (NM_IS_SETTING_VPN (setting), NULL);
return _get_keys (setting, TRUE, out_length);
}

27
shared/nm-utils/nm-compat.h
View file

@ -22,5 +22,32 @@
#ifndef __NM_COMPAT_H__
#define __NM_COMPAT_H__
#include "nm-setting-vpn.h"
const char **_nm_setting_vpn_get_data_keys (NMSettingVpn *setting,
guint *out_length);
const char **_nm_setting_vpn_get_secret_keys (NMSettingVpn *setting,
guint *out_length);
#if NM_CHECK_VERSION (1, 11, 0)
#define nm_setting_vpn_get_data_keys(setting, out_length) \
({ \
G_GNUC_BEGIN_IGNORE_DEPRECATIONS \
nm_setting_vpn_get_data_keys (setting, out_length); \
G_GNUC_END_IGNORE_DEPRECATIONS \
})
#define nm_setting_vpn_get_secret_keys(setting, out_length) \
({ \
G_GNUC_BEGIN_IGNORE_DEPRECATIONS \
nm_setting_vpn_get_secret_keys (setting, out_length); \
G_GNUC_END_IGNORE_DEPRECATIONS \
})
#else
#define nm_setting_vpn_get_data_keys(setting, out_length) \
_nm_setting_vpn_get_data_keys (setting, out_length)
#define nm_setting_vpn_get_secret_keys(setting, out_length) \
_nm_setting_vpn_get_secret_keys (setting, out_length)
#endif
#endif /* __NM_COMPAT_H__ */