From 0c258402c72cf691cf24d0955d2b98a8675cd62a Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Wed, 13 May 2015 13:54:08 +0200 Subject: [PATCH] platform: fix memleak in link_delete() Turns out, the valgrind suppression was hiding a memleak --- src/platform/nm-linux-platform.c | 2 +- valgrind.suppressions | 16 ---------------- 2 files changed, 1 insertion(+), 17 deletions(-) diff --git a/src/platform/nm-linux-platform.c b/src/platform/nm-linux-platform.c index 7f700c2b32..5b9a33f1b8 100644 --- a/src/platform/nm-linux-platform.c +++ b/src/platform/nm-linux-platform.c @@ -2516,7 +2516,7 @@ static gboolean link_delete (NMPlatform *platform, int ifindex) { NMLinuxPlatformPrivate *priv = NM_LINUX_PLATFORM_GET_PRIVATE (platform); - struct rtnl_link *rtnllink = rtnl_link_get (priv->link_cache, ifindex); + auto_nl_object struct rtnl_link *rtnllink = rtnl_link_get (priv->link_cache, ifindex); if (!rtnllink) { platform->error = NM_PLATFORM_ERROR_NOT_FOUND; diff --git a/valgrind.suppressions b/valgrind.suppressions index 5f89c98b1e..b0d5301512 100644 --- a/valgrind.suppressions +++ b/valgrind.suppressions @@ -400,22 +400,6 @@ # libnl3 ############################################################### -{ - libnl_01 - Memcheck:Leak - match-leak-kinds: definite - fun:calloc - fun:nl_object_alloc - fun:link_msg_parser - fun:__pickup_answer - fun:nl_cb_call - fun:recvmsgs - fun:nl_recvmsgs_report - fun:nl_recvmsgs - fun:nl_pickup - fun:rtnl_link_get_kernel - ... -} { # fixed by https://github.com/thom311/libnl/commit/d65c32a7205e679c7fc13f0e4565b13e698ba906 libnl_rtnl_link_set_type_01