mirror of
https://github.com/gravitational/teleport
synced 2024-10-21 01:34:01 +00:00
0a2d90f489
We no longer require the end key for a DeleteRange operation to be a valid backend key. This prevented us from deleting resources ending in 'z', because it would produce an end key that the sanitizer doesn't like. Updates #2776
149 lines
3.5 KiB
Go
149 lines
3.5 KiB
Go
// Copyright 2021 Gravitational, Inc
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package backend
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/jonboulle/clockwork"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestSanitize(t *testing.T) {
|
|
tests := []struct {
|
|
inKey []byte
|
|
assert require.ErrorAssertionFunc
|
|
}{
|
|
{
|
|
inKey: []byte("a-b/c:d/.e_f/01"),
|
|
assert: require.NoError,
|
|
},
|
|
{
|
|
inKey: []byte("/namespaces//params"),
|
|
assert: require.Error,
|
|
},
|
|
{
|
|
inKey: RangeEnd([]byte("a-b/c:d/.e_f/01")),
|
|
assert: require.NoError,
|
|
},
|
|
{
|
|
inKey: RangeEnd([]byte("/")),
|
|
assert: require.NoError,
|
|
},
|
|
{
|
|
inKey: RangeEnd([]byte("Malformed \xf0\x90\x28\xbc UTF8")),
|
|
assert: require.Error,
|
|
},
|
|
{
|
|
inKey: []byte("test+subaddr@example.com"),
|
|
assert: require.NoError,
|
|
},
|
|
{
|
|
inKey: []byte("xyz"),
|
|
assert: require.NoError,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(fmt.Sprintf("%v", string(tt.inKey)), func(t *testing.T) {
|
|
ctx := context.Background()
|
|
safeBackend := NewSanitizer(&nopBackend{})
|
|
|
|
_, err := safeBackend.Get(ctx, tt.inKey)
|
|
tt.assert(t, err)
|
|
|
|
_, err = safeBackend.Create(ctx, Item{Key: tt.inKey})
|
|
tt.assert(t, err)
|
|
|
|
_, err = safeBackend.Put(ctx, Item{Key: tt.inKey})
|
|
tt.assert(t, err)
|
|
|
|
_, err = safeBackend.Update(ctx, Item{Key: tt.inKey})
|
|
tt.assert(t, err)
|
|
|
|
_, err = safeBackend.CompareAndSwap(ctx, Item{Key: tt.inKey}, Item{Key: tt.inKey})
|
|
tt.assert(t, err)
|
|
|
|
err = safeBackend.Delete(ctx, tt.inKey)
|
|
tt.assert(t, err)
|
|
|
|
err = safeBackend.DeleteRange(ctx, tt.inKey, tt.inKey)
|
|
tt.assert(t, err)
|
|
})
|
|
}
|
|
}
|
|
|
|
type nopBackend struct{}
|
|
|
|
func (n *nopBackend) Get(_ context.Context, _ []byte) (*Item, error) {
|
|
return &Item{}, nil
|
|
}
|
|
|
|
func (n *nopBackend) GetRange(_ context.Context, startKey []byte, endKey []byte, limit int) (*GetResult, error) {
|
|
return &GetResult{Items: []Item{
|
|
{Key: []byte("foo"), Value: []byte("bar")},
|
|
}}, nil
|
|
}
|
|
|
|
func (n *nopBackend) Create(_ context.Context, _ Item) (*Lease, error) {
|
|
return &Lease{}, nil
|
|
}
|
|
|
|
func (n *nopBackend) Put(_ context.Context, _ Item) (*Lease, error) {
|
|
return &Lease{}, nil
|
|
}
|
|
|
|
func (n *nopBackend) Update(_ context.Context, _ Item) (*Lease, error) {
|
|
return &Lease{}, nil
|
|
}
|
|
|
|
func (n *nopBackend) CompareAndSwap(_ context.Context, _ Item, _ Item) (*Lease, error) {
|
|
return &Lease{}, nil
|
|
}
|
|
|
|
func (n *nopBackend) Delete(_ context.Context, _ []byte) error {
|
|
return nil
|
|
}
|
|
|
|
func (n *nopBackend) DeleteRange(_ context.Context, _ []byte, _ []byte) error {
|
|
return nil
|
|
}
|
|
|
|
func (n *nopBackend) KeepAlive(_ context.Context, _ Lease, _ time.Time) error {
|
|
return nil
|
|
}
|
|
|
|
func (n *nopBackend) Close() error {
|
|
return nil
|
|
}
|
|
|
|
func (n *nopBackend) Clock() clockwork.Clock {
|
|
return clockwork.NewFakeClock()
|
|
}
|
|
|
|
// NewWatcher returns a new event watcher
|
|
func (n *nopBackend) NewWatcher(ctx context.Context, watch Watch) (Watcher, error) {
|
|
return nil, nil
|
|
}
|
|
|
|
// CloseWatchers closes all the watchers
|
|
// without closing the backend
|
|
func (n *nopBackend) CloseWatchers() {
|
|
|
|
}
|