Commit graph

71 commits

Author SHA1 Message Date
Alan Parra a27efbb663
Include passwordless in testplan (#13039)
Add passwordless-related tests to testplan.

* Include passwordless in testplan
* Update .github/ISSUE_TEMPLATE/testplan.md

Co-authored-by: Lisa Kim <lisa@goteleport.com>
2022-06-02 19:18:54 -03:00
Krzysztof Skrzętnicki a32982936e
Include tctl sso in test plan. Extend SSO guides test plan. (#13058) 2022-06-02 17:33:12 +00:00
STeve (Xin) Huang 5c6deb7d9d
ElastiCache support - the basics (#12209) 2022-05-13 15:09:20 +00:00
Russell Jones cf504afedc Updated automatic backport creation workflow.
Removed automatic creation of backport Pull Requests due to limitations
within GitHub Actions on recursive creation of workflows not allowing
the "Check" workflow to run upon automation creation of the Pull
Request.

As a temporary workaround, prepare the backport branch and provide a
link the user can click on to create the backport Pull Request.
2022-05-02 10:15:26 -07:00
Russell Jones 60b0267956 Added support for automatic backports. 2022-04-28 18:08:54 -07:00
Xin Ding f20087852b
Simplify issue templates (#12157) 2022-04-26 10:41:34 -07:00
Roman Tkachenko caa6915ede
Add proxy jump test case to test plan (#11274) 2022-03-18 17:35:27 -06:00
Nic Klaassen 22fe05db56
Include AWS join methods in test plan (#10704) 2022-03-18 21:44:48 +00:00
Russell Jones 94802175fa Fixed backport assignment issues.
Added ability to detect URLs for issues and deduplicate list of
reviewers.
2022-03-08 18:52:57 -08:00
Russell Jones 50449c27e4 Assign original reviewers for backports.
Updated review assignment logic to assign original reviewers when a
backport PR is found.
2022-03-07 17:19:36 -08:00
Russell Jones de42b31989 Skip COMMENTED review state after APPROVED. 2022-03-07 10:21:53 -08:00
Isaiah Becker-Mayer 896dbbbc47
desktop playback error handling (#10765) 2022-03-03 20:07:38 +00:00
Zac Bergquist ad8f0da43c
Update test plan (#10513)
* Move test plan to an issue template

* Update test plan with new desktop access features

* Add Binaries compatibility to test plan (#10518)

* Updates clipboard support tests (#10521)

* Adds MFA tests for Desktop

* makes browser instructions more precise

Co-authored-by: Jakub Nyckowski <jakub.nyckowski@goteleport.com>
Co-authored-by: Isaiah Becker-Mayer <isaiah@goteleport.com>
2022-02-24 10:45:22 -07:00
rosstimothy 896261acaf
Add more lint coverage (#10049)
* Add more lint coverage

golanglint-ci doesn't pick up subdirectories with their own go.mod
which left certain directories unlinted. To get around this we can
run golanglint-ci directly against those submodules.
2022-02-07 12:03:10 -05:00
Russell Jones 0d65746fa7 Updated assign and check logic for Cloud.
Updated assign and check logic to assign Cloud team reviewers from Core.
2022-02-02 15:54:53 -08:00
Russell Jones 9a8dfc35fa Cleanup of minor bot issues.
* Don't attempt to submit an empty list of labels to GitHub.
* Be less aggressive when labeling docs.
* Use range for loop iteration.
2022-01-20 08:10:49 -08:00
Edoardo Spadolini b9803adeb3
Revert bot changes for vendor/ (#9743)
The bot runs code from the `master` branch even for the stable branches
that still use vendored dependencies, so we should keep ignoring the
`vendor/` directory in the bot, or we might miscategorize PRs.
2022-01-11 20:22:40 +00:00
Zac Bergquist d0eb86191d Remove vendor
- Remove the vendor directory
- Update bot to stop accounting for vendor
- Update linter config
- Remove update-vendor make target
2022-01-07 02:15:11 -07:00
Zac Bergquist 041f1ea697 bot: label PRs that touch lib/events with "audit-log" 2022-01-05 13:24:07 -07:00
Russell Jones 9edf72b86f Fixed missing reviewers issue.
In a3d85ab removed reviewers from jobs that don't require it and did not
update parsing logic. Instead pass reviewers to all jobs as it is not a
secret and will be inlined into actions/bot soon.
2021-12-23 14:24:07 -08:00
Russell Jones a3d85ab5fe Added support for automatic labeling of PRs. 2021-12-23 11:43:56 -08:00
Russell Jones cf7696cad6 Fixed IsInternal issue in Check workflow.
Fixed issue where IsInternal was returning false for docs reviewers in
the Check workflow.
2021-12-14 18:26:20 -08:00
Russell Jones 821e317b3f Updated checking logic for code owners.
Check logic will now approve with two code owner approvals along with
single code owner + code reviewer approval.
2021-12-14 13:51:45 -08:00
quinqu 759f44c1f6 Correct Dismiss function spelling. 2021-12-09 21:58:58 -08:00
Jane Quintero 36e4570db6
Check If HEAD Branch Is A Fork (#9302) 2021-12-09 23:30:48 +00:00
Russell Jones 598e2417ad Update check.yaml 2021-12-08 17:43:59 -08:00
Jane Quintero 9b5fd64431
Check if PR is from a fork before dismissing runs. (#9300) 2021-12-08 16:12:50 -08:00
Jane Quintero 78b273f19e
Trigger Assign workflow on opened and ready_for_review events. (#9272) 2021-12-08 10:17:40 -08:00
Russell Jones 32423dd231 Added more log lines to dismiss workflow. 2021-12-07 20:11:10 -08:00
Russell Jones 675fb3dc09 Fixed error in assignment logic.
Fixed error in assignment logic where some admin reviewers were omitted.
2021-12-03 14:22:12 -08:00
Russell Jones 0e96258067 Added extra logging to bot assignment. 2021-12-03 12:29:06 -08:00
Russell Jones edcfccea43 Updated logic to find workflow by path. 2021-12-02 14:14:26 -08:00
Russell Jones bfbf021197 Updated code review assignment logic.
Code reviewers are split into code owners and code reviewers. Each PR is
now randomly assigned a reviewers from the code owner and reviewer set.
Review checking makes sure that a reviewer from each set has approved
the PR.
2021-12-02 13:54:24 -08:00
Zac Bergquist 53562aadb0
Use t.Setenv in tests (#9154)
This new feature in Go 1.17 automatically restores the environment
variable to its previous value when a test ends, making it simpler
to set up the environment for tests and less likely that we accidentally
leave behind global state.

Also convert some of the remaining uses of check to standard Go tests.
2021-12-01 10:43:12 -07:00
Jane Quintero 3dbbd1be2c
Don't Dismiss Dismissed Reviews (#9094) 2021-11-23 13:39:53 -08:00
Jane Quintero 65e8ff64e7
Add Bot Logging (#9099) 2021-11-23 09:36:50 -08:00
Jane Quintero e8ff0a6e2e
Keep Valid Reviews For External Contributors (#9067) 2021-11-19 15:24:39 -08:00
Roman Tkachenko e59c04e8bc
Update reviewers (#9050)
Co-authored-by: Russell Jones <russjones@users.noreply.github.com>
2021-11-18 10:02:24 -08:00
Jane Quintero f1ccbff523
Re-Request Reviews When Approvals Are Invalidated (#9037) 2021-11-17 15:10:30 -08:00
Russell Jones a76e05cee3 Update CODEOWNERS 2021-11-12 16:45:49 -08:00
Jane Quintero 54f000d125
Update username (#8968) 2021-11-12 11:33:31 -08:00
Jane Quintero a28bb903fb
Assign Doc Reviewers to Pull Requests with Changes to docs/ (#8938) 2021-11-12 08:37:25 -08:00
Jane Quintero 853da7716d
Bypass required reviewers (#8901) 2021-11-11 15:59:07 -08:00
Russell Jones 0aee538790 Update check.go 2021-11-10 15:08:46 -08:00
Jane Quintero 391884ec16
Use Hardcoded Map to Get Reviewers for Authors (#8928) 2021-11-10 14:29:00 -08:00
Jane Quintero 526f33cd02
Do Not Dismiss Commented Pull Request Reviews (#8912) 2021-11-10 11:57:58 -08:00
Jane Quintero 953f53d65f
Add space between reviewer usernames (#8905) 2021-11-10 11:31:28 -08:00
quinqu 6801981aa4 remove checking if users exist 2021-11-10 10:28:20 -08:00
Jane Quintero 52bf810398
Update workflow files to run workflows in the context of master (#8728) 2021-11-03 11:31:48 -07:00
Jane Quintero 6d0fa6f794
Update GH Actions Workflow Commands (#8724)
Update path in command for Github Actions (Assign and Check workflows)
2021-10-25 15:27:26 -07:00