self-hosted/teleport
self-hosted/teleport
1
0
Fork 0
mirror of https://github.com/gravitational/teleport synced 2024-10-21 17:53:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Lower EC2 label log frequency (#15179)

Browse source 
This change makes the error message for when EC2 tags aren't available in instance metadata only emit once, to reduce log spam.

Co-authored-by: Roman Tkachenko <roman@goteleport.com>
This commit is contained in:
Andrew Burke 2022-08-15 10:01:04 -07:00 committed by GitHub
parent f56dd09ebd
commit d46ccb22ab
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
lib/labels/ec2/ec2.go
View file

@ -70,6 +70,9 @@ type EC2 struct {
labels map[string]string
closeCh chan struct{}
// loggedInstanceTagsNotFound is used to ensure that the error message for
// incorrectly configured instance metadata is only logged once.
loggedInstanceTagsNotFound bool
}
func New(ctx context.Context, c *Config) (*EC2, error) {
@ -110,11 +113,16 @@ func (l *EC2) Sync(ctx context.Context) error {
tags, err := l.c.Client.GetTagKeys(ctx)
if err != nil {
if trace.IsNotFound(err) {
l.c.Log.Warningf("could not fetch tags, please ensure 'allow instance tags in metadata' is enabled on the instance")
// Only show the error the first time around.
if !l.loggedInstanceTagsNotFound {
l.loggedInstanceTagsNotFound = true
l.c.Log.Warning("Could not fetch EC2 instance's tags, please ensure 'allow instance tags in metadata' is enabled on the instance.")
}
return nil
}
return trace.Wrap(err)
}
l.loggedInstanceTagsNotFound = false
currentLabels := l.Get()
var errors []error