update code review comments

This commit is contained in:
Sasha Klizhentas 2016-07-29 09:55:13 -07:00
parent 6bb48bb850
commit a4dcebf127

View file

@ -470,7 +470,10 @@ func (s *APIServer) generateUserCert(w http.ResponseWriter, r *http.Request, _ h
// This allows us to make sure that users can only request new certificates
// only for themselves, except admin users
caller, _, ok := r.BasicAuth()
if !ok || (req.User != caller && s.a.role != teleport.RoleAdmin) {
if !ok {
return nil, trace.AccessDenied("Missing username or password")
}
if req.User != caller && s.a.role != teleport.RoleAdmin {
return nil, trace.AccessDenied("User %s cannot request a certificate for %s",
caller, req.User)
}