Merge pull request #949 from gravitational/rjones/roles-set-defaults

Use CheckAndSetDefaults in tctl and add KindNode to default list of

lib/services/role.go

@@ -147,6 +147,8 @@ type Role interface {
 	CanForwardAgent() bool
 	// SetForwardAgent sets forward agent property
 	SetForwardAgent(forwardAgent bool)
+	// CheckAndSetDefaults checks and set default values for missing fields.
+	CheckAndSetDefaults() error
 }
 
 // RoleV2 represents role resource specification

lib/web/ui/roleaccess.go

@@ -21,6 +21,7 @@ var adminResources = []string{
 	teleservices.KindCertAuthority,
 	teleservices.KindReverseTunnel,
 	teleservices.KindTrustedCluster,
+	teleservices.KindNode,
 }
 
 // AdminAccess describes admin access

tool/tctl/common/tctl.go

@@ -998,6 +998,10 @@ func (u *CreateCommand) Create(client *auth.TunClient) error {
 			if err != nil {
 				return trace.Wrap(err)
 			}
+			err = role.CheckAndSetDefaults()
+			if err != nil {
+				return trace.Wrap(err)
+			}
 			if err := client.UpsertRole(role, backend.Forever); err != nil {
 				return trace.Wrap(err)
 			}