self-hosted/teleport
self-hosted/teleport
1
0
Fork 0
mirror of https://github.com/gravitational/teleport synced 2024-10-21 01:34:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove checking for error from session end in web terminal (#8797)

Browse source 
Removes the call for wait for ssh.Session end to check for errors
in web terminal which fixes a regression bug where typing "exit" 
in web terminal does not return session end event. 
PR #8081 removed the need to check for errors as it correctly 
returns exit errors whereas before it returned nil.
This commit is contained in:
Lisa Kim 2021-11-01 17:55:59 -07:00 committed by GitHub
parent 878539bf49
commit 092e3ab72e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
lib/web/terminal.go
View file

@ -494,16 +494,6 @@ func (t *TerminalHandler) streamTerminal(ws *websocket.Conn, tc *client.Teleport
return
}
// Check if remote process exited with error code, eg: RemoteCommandFailure (255).
if t.sshSession != nil {
if err := t.sshSession.Wait(); err != nil {
if exitErr, ok := err.(*ssh.ExitError); ok {
t.log.Warnf("Remote shell exited with error code: %v", exitErr.ExitStatus())
return
}
}
}
// Send close envelope to web terminal upon exit without an error.
envelope := &Envelope{
Version: defaults.WebsocketVersion,