mirror of
https://github.com/minio/minio
synced 2024-09-06 08:44:03 +00:00
![Harshavardhana](/assets/img/avatar_default.png)
Update reedsolomon library to enable feature to automatically set number of go-routines based on the input shard size, since shard size is sort of a constant in Minio for objects > 10MiB (default blocksize) klauspost reported around 15-20% improvement in performance numbers on older systems such as AVX and SSE3 ``` name old speed new speed delta Encode10x2x10000-8 5.45GB/s ± 1% 6.22GB/s ± 1% +14.20% (p=0.000 n=9+9) Encode100x20x10000-8 1.44GB/s ± 1% 1.64GB/s ± 1% +13.77% (p=0.000 n=10+10) Encode17x3x1M-8 10.0GB/s ± 5% 12.0GB/s ± 1% +19.88% (p=0.000 n=10+10) Encode10x4x16M-8 7.81GB/s ± 5% 8.56GB/s ± 5% +9.58% (p=0.000 n=10+9) Encode5x2x1M-8 15.3GB/s ± 2% 19.6GB/s ± 2% +28.57% (p=0.000 n=9+10) Encode10x2x1M-8 12.2GB/s ± 5% 15.0GB/s ± 5% +22.45% (p=0.000 n=10+10) Encode10x4x1M-8 7.84GB/s ± 1% 9.03GB/s ± 1% +15.19% (p=0.000 n=9+9) Encode50x20x1M-8 1.73GB/s ± 4% 2.09GB/s ± 4% +20.59% (p=0.000 n=10+9) Encode17x3x16M-8 10.6GB/s ± 1% 11.7GB/s ± 4% +10.12% (p=0.000 n=8+10) ```
118 lines
3.9 KiB
Go
118 lines
3.9 KiB
Go
/*
|
|
* Minio Cloud Storage, (C) 2017 Minio, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"crypto/subtle"
|
|
"hash"
|
|
|
|
"github.com/klauspost/reedsolomon"
|
|
"github.com/minio/minio/pkg/errors"
|
|
)
|
|
|
|
// OfflineDisk represents an unavailable disk.
|
|
var OfflineDisk StorageAPI // zero value is nil
|
|
|
|
// ErasureFileInfo contains information about an erasure file operation (create, read, heal).
|
|
type ErasureFileInfo struct {
|
|
Size int64
|
|
Algorithm BitrotAlgorithm
|
|
Checksums [][]byte
|
|
}
|
|
|
|
// ErasureStorage represents an array of disks.
|
|
// The disks contain erasure coded and bitrot-protected data.
|
|
type ErasureStorage struct {
|
|
disks []StorageAPI
|
|
erasure reedsolomon.Encoder
|
|
dataBlocks, parityBlocks int
|
|
}
|
|
|
|
// NewErasureStorage creates a new ErasureStorage. The storage erasure codes and protects all data written to
|
|
// the disks.
|
|
func NewErasureStorage(disks []StorageAPI, dataBlocks, parityBlocks int, blockSize int64) (s ErasureStorage, err error) {
|
|
shardsize := (int(blockSize) + dataBlocks - 1) / dataBlocks
|
|
erasure, err := reedsolomon.New(dataBlocks, parityBlocks, reedsolomon.WithAutoGoroutines(shardsize))
|
|
if err != nil {
|
|
return s, errors.Tracef("failed to create erasure coding: %v", err)
|
|
}
|
|
s = ErasureStorage{
|
|
disks: make([]StorageAPI, len(disks)),
|
|
erasure: erasure,
|
|
dataBlocks: dataBlocks,
|
|
parityBlocks: parityBlocks,
|
|
}
|
|
copy(s.disks, disks)
|
|
return
|
|
}
|
|
|
|
// ErasureEncode encodes the given data and returns the erasure-coded data.
|
|
// It returns an error if the erasure coding failed.
|
|
func (s *ErasureStorage) ErasureEncode(data []byte) ([][]byte, error) {
|
|
encoded, err := s.erasure.Split(data)
|
|
if err != nil {
|
|
return nil, errors.Tracef("failed to split data: %v", err)
|
|
}
|
|
if err = s.erasure.Encode(encoded); err != nil {
|
|
return nil, errors.Tracef("failed to encode data: %v", err)
|
|
}
|
|
return encoded, nil
|
|
}
|
|
|
|
// ErasureDecodeDataBlocks decodes the given erasure-coded data.
|
|
// It only decodes the data blocks but does not verify them.
|
|
// It returns an error if the decoding failed.
|
|
func (s *ErasureStorage) ErasureDecodeDataBlocks(data [][]byte) error {
|
|
if err := s.erasure.ReconstructData(data); err != nil {
|
|
return errors.Tracef("failed to reconstruct data: %v", err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// ErasureDecodeDataAndParityBlocks decodes the given erasure-coded data and verifies it.
|
|
// It returns an error if the decoding failed.
|
|
func (s *ErasureStorage) ErasureDecodeDataAndParityBlocks(data [][]byte) error {
|
|
if err := s.erasure.Reconstruct(data); err != nil {
|
|
return errors.Tracef("failed to reconstruct data: %v", err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// NewBitrotVerifier returns a new BitrotVerifier implementing the given algorithm.
|
|
func NewBitrotVerifier(algorithm BitrotAlgorithm, checksum []byte) *BitrotVerifier {
|
|
return &BitrotVerifier{algorithm.New(), algorithm, checksum, false}
|
|
}
|
|
|
|
// BitrotVerifier can be used to verify protected data.
|
|
type BitrotVerifier struct {
|
|
hash.Hash
|
|
|
|
algorithm BitrotAlgorithm
|
|
sum []byte
|
|
verified bool
|
|
}
|
|
|
|
// Verify returns true iff the computed checksum of the verifier matches the the checksum provided when the verifier
|
|
// was created.
|
|
func (v *BitrotVerifier) Verify() bool {
|
|
v.verified = true
|
|
return subtle.ConstantTimeCompare(v.Sum(nil), v.sum) == 1
|
|
}
|
|
|
|
// IsVerified returns true iff Verify was called at least once.
|
|
func (v *BitrotVerifier) IsVerified() bool { return v.verified }
|