mirror of
https://github.com/minio/minio
synced 2024-10-06 07:59:36 +00:00
6c89a81af4
`(*xlStorageDiskIDCheck).CreateFile` wraps the incoming reader in `xioutil.NewDeadlineReader`. The wrapped reader is handed to `(*xlStorage).CreateFile`. This performs a Read call via `writeAllDirect`, which reads into an `ODirectPool` buffer. `(*DeadlineReader).Read` spawns an async read into the buffer. If a timeout is hit while reading, the read operation returns to `writeAllDirect`. The operation returns an error and the buffer is reused. However, if the async `Read` call unblocks, it will write to the now recycled buffer. Fix: Remove the `DeadlineReader` - it is inherently unsafe. Instead, rely on the network timeouts. This is not a disk timeout, anyway. Regression in https://github.com/minio/minio/pull/17745 |
||
|---|---|---|
| .. | ||
| append-file_nix.go | ||
| append-file_windows.go | ||
| discard.go | ||
| hardlimitreader.go | ||
| ioutil.go | ||
| ioutil_test.go | ||
| read_file.go | ||
| read_file_noatime_notsupported.go | ||
| read_file_noatime_supported.go | ||
| wait_pipe.go | ||