mirror of
https://github.com/minio/minio
synced 2024-09-06 00:37:25 +00:00
![Harshavardhana](/assets/img/avatar_default.png)
This is an attempt cleanup code and keep the top level config functions simpler and easy to understand where as move the notifier related code and logger setter/getter methods as part of their own struct. Locks are now held properly not globally by configMutex, but instead as private variables. Final fix for #3700
80 lines
2.1 KiB
Go
80 lines
2.1 KiB
Go
/*
|
|
* Minio Cloud Storage, (C) 2017 Minio, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"fmt"
|
|
"io"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"path"
|
|
"testing"
|
|
|
|
"github.com/Sirupsen/logrus"
|
|
)
|
|
|
|
// Custom post handler to handle POST requests.
|
|
type postHandler struct{}
|
|
|
|
func (p postHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
|
|
if r.Method != "POST" {
|
|
http.Error(w, fmt.Sprintf("Unexpected method %s", r.Method), http.StatusBadRequest)
|
|
return
|
|
}
|
|
io.Copy(w, r.Body)
|
|
}
|
|
|
|
// Tests web hook initialization.
|
|
func TestNewWebHookNotify(t *testing.T) {
|
|
root, err := newTestConfig(globalMinioDefaultRegion)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer removeAll(root)
|
|
|
|
_, err = newWebhookNotify("1")
|
|
if err == nil {
|
|
t.Fatal("Unexpected should fail")
|
|
}
|
|
|
|
serverConfig.Notify.SetWebhookByID("10", webhookNotify{Enable: true, Endpoint: "http://www."})
|
|
_, err = newWebhookNotify("10")
|
|
if err == nil {
|
|
t.Fatal("Unexpected should fail with lookupHost")
|
|
}
|
|
|
|
serverConfig.Notify.SetWebhookByID("15", webhookNotify{Enable: true, Endpoint: "http://%"})
|
|
_, err = newWebhookNotify("15")
|
|
if err == nil {
|
|
t.Fatal("Unexpected should fail with invalid URL escape")
|
|
}
|
|
|
|
server := httptest.NewServer(postHandler{})
|
|
defer server.Close()
|
|
|
|
serverConfig.Notify.SetWebhookByID("20", webhookNotify{Enable: true, Endpoint: server.URL})
|
|
webhook, err := newWebhookNotify("20")
|
|
if err != nil {
|
|
t.Fatal("Unexpected shouldn't fail", err)
|
|
}
|
|
|
|
webhook.WithFields(logrus.Fields{
|
|
"Key": path.Join("bucket", "object"),
|
|
"EventType": "s3:ObjectCreated:Put",
|
|
}).Info()
|
|
}
|