From 6d44274db68f22b6c7a67d0f9387cf998087ddda Mon Sep 17 00:00:00 2001 From: Harshavardhana Date: Tue, 9 Jun 2015 01:12:32 -0700 Subject: [PATCH] Make sure to reply back ETag with quotes for s3 compliance --- NOTICE | 2 +- pkg/api/api_response.go | 4 ++-- pkg/erasure/README.md | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/NOTICE b/NOTICE index d731663e0..c6336c945 100644 --- a/NOTICE +++ b/NOTICE @@ -1,7 +1,7 @@ Minimalist Object Storage, (C) 2014,2015 Minio, Inc. This product includes software developed at Minio, Inc. -(http://minio.io/). +(https://minio.io/). The Minio project contains unmodified/modified subcomponents too with separate copyright notices and license terms. Your use of the source diff --git a/pkg/api/api_response.go b/pkg/api/api_response.go index b17eb2d74..509e4818f 100644 --- a/pkg/api/api_response.go +++ b/pkg/api/api_response.go @@ -86,7 +86,7 @@ func generateListObjectsResponse(bucket string, objects []drivers.ObjectMetadata } content.Key = object.Key content.LastModified = object.Created.Format(iso8601Format) - content.ETag = object.Md5 + content.ETag = "\"" + object.Md5 + "\"" content.Size = object.Size content.StorageClass = "STANDARD" content.Owner = owner @@ -152,7 +152,7 @@ func generateListPartsResult(objectMetadata drivers.ObjectResourcesMetadata) Lis for _, part := range objectMetadata.Part { newPart := &Part{} newPart.PartNumber = part.PartNumber - newPart.ETag = part.ETag + newPart.ETag = "\"" + part.ETag + "\"" newPart.Size = part.Size newPart.LastModified = part.LastModified.Format(iso8601Format) listPartsResponse.Part = append(listPartsResponse.Part, newPart) diff --git a/pkg/erasure/README.md b/pkg/erasure/README.md index 6a1fa2bee..4cef6311b 100644 --- a/pkg/erasure/README.md +++ b/pkg/erasure/README.md @@ -6,7 +6,7 @@ Erasure is an open source Golang library written on top of ISAL (Intel Intellige * [Get Source](./CONTRIBUTING.md) * [Build Dependencies](./BUILDDEPS.md) * [Development Workflow](./CONTRIBUTING.md#developer-guidelines) -* [Developer discussions and bugs](https://github.com/minio/erasure/issues) +* [Developer discussions and bugs](https://github.com/minio/minio/issues) ### Supported platforms