diff --git a/internal/logger/target/http/http.go b/internal/logger/target/http/http.go index f811965a6..56b18661b 100644 --- a/internal/logger/target/http/http.go +++ b/internal/logger/target/http/http.go @@ -128,9 +128,6 @@ func acceptedResponseStatusCode(code int) bool { } func (h *Target) logEntry(entry interface{}) { - h.wg.Add(1) - defer h.wg.Done() - logJSON, err := json.Marshal(&entry) if err != nil { return @@ -181,6 +178,8 @@ func (h *Target) startHTTPLogger() { // Create a routine which sends json logs received // from an internal channel. go func() { + h.wg.Add(1) + defer h.wg.Done() for entry := range h.logCh { h.logEntry(entry) } diff --git a/internal/logger/target/kafka/kafka.go b/internal/logger/target/kafka/kafka.go index 08003a4d0..39f63a87c 100644 --- a/internal/logger/target/kafka/kafka.go +++ b/internal/logger/target/kafka/kafka.go @@ -27,7 +27,7 @@ import ( "sync" "sync/atomic" - sarama "github.com/Shopify/sarama" + "github.com/Shopify/sarama" saramatls "github.com/Shopify/sarama/tools/tls" "github.com/minio/minio/internal/logger/message/audit" @@ -62,9 +62,6 @@ func (h *Target) Send(entry interface{}, errKind string) error { } func (h *Target) logEntry(entry interface{}) { - h.wg.Add(1) - defer h.wg.Done() - logJSON, err := json.Marshal(&entry) if err != nil { return @@ -90,6 +87,8 @@ func (h *Target) startKakfaLogger() { // Create a routine which sends json logs received // from an internal channel. go func() { + h.wg.Add(1) + defer h.wg.Done() for entry := range h.logCh { h.logEntry(entry) }