From 23e4895dfcf84b230f78e2e0e7c9c5ec04937a3a Mon Sep 17 00:00:00 2001
From: Yang Wu <wuyangmuc@gmail.com>
Date: Mon, 7 Aug 2023 17:21:22 +0800
Subject: [PATCH] Create metrics slice when necessary (#17809)

---
 cmd/metrics-v2.go | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/cmd/metrics-v2.go b/cmd/metrics-v2.go
index 351e4e478..53a4395ef 100644
--- a/cmd/metrics-v2.go
+++ b/cmd/metrics-v2.go
@@ -1214,7 +1214,7 @@ func getMinioProcMetrics() *MetricsGroup {
 		if runtime.GOOS == "windows" {
 			return nil
 		}
-		metrics = make([]Metric, 0, 20)
+
 		p, err := procfs.Self()
 		if err != nil {
 			logger.LogOnceIf(ctx, err, string(nodeMetricNamespace))
@@ -1227,6 +1227,8 @@ func getMinioProcMetrics() *MetricsGroup {
 		stat, _ := p.Stat()
 		startTime, _ := stat.StartTime()
 
+		metrics = make([]Metric, 0, 20)
+
 		if openFDs > 0 {
 			metrics = append(metrics,
 				Metric{
@@ -1794,7 +1796,6 @@ func getMinioHealingMetrics() *MetricsGroup {
 		cacheInterval: 10 * time.Second,
 	}
 	mg.RegisterRead(func(_ context.Context) (metrics []Metric) {
-		metrics = make([]Metric, 0, 5)
 		bgSeq, exists := globalBackgroundHealState.getHealSequenceByToken(bgHealingUUID)
 		if !exists {
 			return
@@ -1804,6 +1805,7 @@ func getMinioHealingMetrics() *MetricsGroup {
 			return
 		}
 
+		metrics = make([]Metric, 0, 5)
 		metrics = append(metrics, Metric{
 			Description: getHealLastActivityTimeMD(),
 			Value:       float64(time.Since(bgSeq.lastHealActivity)),