From fde03d7888e3c25e8a34cd452290f2db8e605316 Mon Sep 17 00:00:00 2001 From: Marc Mueller <30130371+cdce8p@users.noreply.github.com> Date: Tue, 2 Jan 2024 20:41:39 +0100 Subject: [PATCH] Enable strict typing for co2signal (#106888) --- .strict-typing | 1 + homeassistant/components/co2signal/helpers.py | 6 ++++-- homeassistant/components/co2signal/util.py | 5 +++-- mypy.ini | 10 ++++++++++ 4 files changed, 18 insertions(+), 4 deletions(-) diff --git a/.strict-typing b/.strict-typing index a976deed8c1c..f04d8d85e98f 100644 --- a/.strict-typing +++ b/.strict-typing @@ -116,6 +116,7 @@ homeassistant.components.clickatell.* homeassistant.components.clicksend.* homeassistant.components.climate.* homeassistant.components.cloud.* +homeassistant.components.co2signal.* homeassistant.components.command_line.* homeassistant.components.configurator.* homeassistant.components.cover.* diff --git a/homeassistant/components/co2signal/helpers.py b/homeassistant/components/co2signal/helpers.py index 937b72a357ce..d64a0abb1e7c 100644 --- a/homeassistant/components/co2signal/helpers.py +++ b/homeassistant/components/co2signal/helpers.py @@ -1,4 +1,6 @@ """Helper functions for the CO2 Signal integration.""" +from __future__ import annotations + from collections.abc import Mapping from typing import Any @@ -16,11 +18,11 @@ async def fetch_latest_carbon_intensity( ) -> CarbonIntensityResponse: """Fetch the latest carbon intensity based on country code or location coordinates.""" if CONF_COUNTRY_CODE in config: - return await em.latest_carbon_intensity_by_country_code( + return await em.latest_carbon_intensity_by_country_code( # type: ignore[no-any-return] code=config[CONF_COUNTRY_CODE] ) - return await em.latest_carbon_intensity_by_coordinates( + return await em.latest_carbon_intensity_by_coordinates( # type: ignore[no-any-return] lat=config.get(CONF_LATITUDE, hass.config.latitude), lon=config.get(CONF_LONGITUDE, hass.config.longitude), ) diff --git a/homeassistant/components/co2signal/util.py b/homeassistant/components/co2signal/util.py index 68403b4803e7..b588e0abef94 100644 --- a/homeassistant/components/co2signal/util.py +++ b/homeassistant/components/co2signal/util.py @@ -2,14 +2,15 @@ from __future__ import annotations from collections.abc import Mapping +from typing import Any from homeassistant.const import CONF_COUNTRY_CODE, CONF_LATITUDE, CONF_LONGITUDE -def get_extra_name(config: Mapping) -> str | None: +def get_extra_name(config: Mapping[str, Any]) -> str | None: """Return the extra name describing the location if not home.""" if CONF_COUNTRY_CODE in config: - return config[CONF_COUNTRY_CODE] + return config[CONF_COUNTRY_CODE] # type: ignore[no-any-return] if CONF_LATITUDE in config: return f"{round(config[CONF_LATITUDE], 2)}, {round(config[CONF_LONGITUDE], 2)}" diff --git a/mypy.ini b/mypy.ini index 7a2e16c37ed8..a65df261427f 100644 --- a/mypy.ini +++ b/mypy.ini @@ -920,6 +920,16 @@ disallow_untyped_defs = true warn_return_any = true warn_unreachable = true +[mypy-homeassistant.components.co2signal.*] +check_untyped_defs = true +disallow_incomplete_defs = true +disallow_subclassing_any = true +disallow_untyped_calls = true +disallow_untyped_decorators = true +disallow_untyped_defs = true +warn_return_any = true +warn_unreachable = true + [mypy-homeassistant.components.command_line.*] check_untyped_defs = true disallow_incomplete_defs = true