mirror of
https://github.com/caddyserver/caddy
synced 2024-10-19 08:33:27 +00:00
402f423693
Tested for memory leaks and performance. Obviously the added locking and global state is not awesome, but the alternative is a little uglier IMO: we'd have to make some sort of "liaison" value which stores the state, then pass it around to every module, and so LoadModule becomes a lot less accessible, and each module would need to maintain a reference to it... nope, just ugly. I think this is the cleaner solution: just make sure only one Start() happens at a time, and keep global things global. Very simple log middleware is an example. Might need to reorder the operations in Start() and handle errors differently, etc. Otherwise, I'm mostly happy with this solution... |
||
|---|---|---|
| cmd/caddy2 | ||
| modules/caddyhttp | ||
| .gitignore | ||
| admin.go | ||
| admin_test.go | ||
| caddy.go | ||
| listeners.go | ||
| modules.go | ||
| modules_test.go | ||