mirror of
https://invent.kde.org/graphics/okular
synced 2024-09-13 13:11:41 +00:00
dccd83783d
bd20e48c3c
updated Okular's copy of the synctex code to 1.19.
Unfortunately since this version the upstream code logs errors like
`"! SyncTeX Error : Ignored record...` when accessing selected synctex
files created with older versions of synctex.
The upstream `_synctex_log` contains `va_list arg` as a parameter, but
fails to initialize and tear down this properly via `va_start` and
`va_end`. In general this seems to work for the single argument case.
However, once we apply our hardening patch to get rid of the
`gnu_printf format attribute` warning and thus introduce a variadic
argument, things go wrong.
To fix this, we add the missing code. The remaining changes are just
refreshing the patches.
BUG: 383915
Test Plan:
Opening `empty.pdf` with `empty.synctex.gz` from
https://bugs.kde.org/attachment.cgi?id=109116 located
in the same folder does not lead to Okular segfaulting anymore.
18 lines
883 B
Diff
18 lines
883 B
Diff
Fix some typos found by Krazy2
|
|
Author: Yuri Chornoivan <yurchor@ukr.net>
|
|
Original commit: 3b73357
|
|
|
|
Index: synctex/synctex_parser_utils.c
|
|
===================================================================
|
|
--- synctex.orig/synctex_parser_utils.c
|
|
+++ synctex/synctex_parser_utils.c
|
|
@@ -410,7 +410,7 @@ char * _synctex_merge_strings(const char
|
|
|
|
/* The purpose of _synctex_get_name is to find the name of the synctex file.
|
|
* There is a list of possible filenames from which we return the most recent one and try to remove all the others.
|
|
- * With two runs of pdftex or xetex we are sure the the synctex file is really the most appropriate.
|
|
+ * With two runs of pdftex or xetex we are sure the synctex file is really the most appropriate.
|
|
*/
|
|
int _synctex_get_name(const char * output, const char * build_directory, char ** synctex_name_ref, synctex_io_mode_t * io_mode_ref)
|
|
{
|