Commit graph

501 commits

Author SHA1 Message Date
Fabio D'Urso ef7aaaf4d5 updateCursor: small change to reflect that only Browse mode lets you interact with links/annotations
This patch only changes the code, the resulting behavior hasn't changed
2013-07-31 00:02:12 +02:00
Fabio D'Urso 8bf046371a Centralize cursor selection logic during creation of annotations into updateCursor 2013-07-31 00:02:07 +02:00
Yuri Chornoivan 3b73357d2f Fix some typos found by Krazy2 2013-06-24 13:46:16 +03:00
Peter Grasch 09dad5e6d2 Usability: Use crosshair cursor while annotating
REVIEW: 109633

updateCursor changes by Albert
2013-06-23 20:45:04 +02:00
Jon Mease b7ce9114c5 Undo support for PDF forms
Together with the already commited support for undo in annotations fixes 177501
BUGS: 177501
REVIEW: 110589
FIXED-IN: 4.11.0
2013-06-03 22:46:41 +02:00
Fabio D'Urso 5860fc89c5 Added shortcut to annotation config panel as review toolbar's context menu 2013-05-28 23:55:10 +02:00
Fabio D'Urso 9e7cf9ae4b Merge remote-tracking branch 'origin/master' into configurable-review-tools 2013-05-20 20:28:49 +02:00
Albert Astals Cid 446a636abf Merge remote-tracking branch 'origin/KDE/4.10' 2013-05-20 18:22:56 +02:00
Albert Astals Cid 4e05cc2526 Fix wrong check
Parker messed up the logic that force it to be in text selection mode
to be on non text selecion mode when doing an unrelated change.

As the "bug" as showed we can selectAll in non text selection mode as well
so remove the check altogether

BUGS: 159276, 319554
FIXED-IN: 4.10.4
2013-05-20 18:15:55 +02:00
Fabio D'Urso 2e0296e913 Merge remote-tracking branch 'origin/master' into configurable-review-tools
Conflicts:
	ui/pageview.cpp
	ui/pageviewannotator.cpp
2013-04-19 01:17:56 +02:00
Jon Mease 78faf1e68f Add undo/redo support for annotations
REVIEW: 107442
2013-04-06 00:22:48 +02:00
Jaydeep Solanki 1121cff1b8 Implement Open url in browser for plain text
BUGS: 281027
REVIEW: 108614
FIXED-IN: 4.11.0
2013-03-26 22:43:56 +01:00
Albert Astals Cid 04c3b836ff Merge remote-tracking branch 'origin/KDE/4.10'
Conflicts:
	generators/spectre/okularApplication_ghostview.desktop
2013-03-14 23:09:57 +01:00
Albert Astals Cid 3f3f82afa1 Fix my email address 2013-03-14 23:09:07 +01:00
Albert Astals Cid 541650a4f4 Remove the concept of observer/view id
Just use the pointer as id :-)

This is BIC and SIC, increase the soversion now to makes sure we don't forget in the future

Patch based in an earlier patch by Bogdan Cristea <cristeab@gmail.com>
REVIEW: 109115
2013-02-24 23:01:02 +01:00
Albert Astals Cid 56e20047b8 Repaint on config change
Now that the pdf generator does not incorrectly delete the pixmaps
on a config change we need to repaint the viewports in case
there has been a inverted color change or something similar
2012-12-31 12:04:23 +01:00
Fabio D'Urso c9e5d0a0b0 Make PageViewAnnotator reparse tool list on configuration change
This doesn't do anything useful at the moment. In next patch I'll turn
the tool list into a configurable option.
2012-12-27 19:38:43 +01:00
Fabio D'Urso 5b8d51d66e Fixed wrong index
BUG: 311601
2012-12-13 11:40:28 +01:00
Albert Astals Cid 7ba2f70453 Remove duplicated code 2012-12-12 22:23:17 +01:00
Albert Astals Cid f70c31aed6 Some const 2012-12-12 22:23:17 +01:00
Fabio D'Urso 7cdc42a682 Hide widget annotations from the user (some other checks)
This patch also prevents the popup window from being opened on
double-click and the annotation tooltip from being shown.
2012-12-12 20:01:46 +01:00
Tobias Koenig 38861f5f57 Hide widget annotations from the user
Widget annotations are not meant to behave like "regular" annotations.
In particular, they must not be listed in the review panel or when the
user right-clicks on form fields.
2012-12-12 19:33:48 +01:00
Fabio D'Urso 9101f9b410 Two changes in PageView's zoom combobox
- Removed useless document->supportsTiles() check in setupBaseActions()
   setupBaseActions() is called only once, before a document is opened,
   therefore supportsTiles() always returns false
 - Show the 400% entry even when tiled rendering is not available, so
   that the last entry always corresponds to the maximum allowed zoom
   level (i.e. 1600% or 400% according to whether tiled rendering is
   available or not)
2012-12-01 01:34:54 +01:00
Mailson Menezes 7528fb8c88 Change TilesManager::tilesAt use
- The second parameter has changed to an enum
 - Now Page::tilesAt only returns tiles with pixmaps
2012-11-15 20:41:17 -03:00
Mailson Menezes 66e93136f9 Limit zoom to 400% if document doesn't support tiles 2012-11-15 20:24:51 -03:00
Fabio D'Urso 0a64022a61 pagepainter: Fix wrong positioning of tiles if trim margins is on
This patch breaks positioning of other objects, which will be fixed in the
next patch.
2012-11-15 22:48:08 +01:00
Mailson Menezes d2d2fa3b2a Refactoring PageView 2012-11-12 13:11:34 -03:00
Fabio D'Urso 85d5f043a2 Removed useless Tile::operator= 2012-11-09 17:49:23 +01:00
Albert Astals Cid bb9508e2f4 Be const my friend 2012-11-09 01:10:43 +01:00
Mailson Menezes f56c5a8ac9 Merge branch 'master' into tiled-rendering 2012-11-08 20:51:01 -03:00
Fabio D'Urso 437ddad588 Hide tiles manager within okularcore
Only the Tile class (tile.h) is visible from the outside
2012-11-08 20:26:17 -03:00
Fabio D'Urso e12966b259 Removed possibility to have a tiles manager per observer
Now only the PageView can have a tiles manager.
2012-11-08 20:52:01 +01:00
Mailson Menezes f91f55d117 Split tile structure in Tile and TileNode
The new class TileNode represents a node in the tree structure
whereas Tile is just a data structure to store the pixmap and tile rect
and is used outside tiles manager.
2012-11-08 14:44:57 -03:00
Mailson Menezes da54ffdd8e Improve the evicting algorithm
The miss counter was taken away. Now the algorithm relies on the
distance between the tiles and the viewport.

Also the visibleRect() and setVisibleRect() methods were removed from
TilesManager since we now pass this information to
TilesManager::cleanupPixmapMemory()
2012-11-08 10:58:08 -03:00
Tobias Koenig 6dddb7eff8 Adapt PageView and PresentationWidget to handle ScreenAnnotations correctly
REVIEW: 106986
2012-10-25 08:30:41 +02:00
Tobias Koenig d68bba55b4 Make VideoWidget independet of associated annotation type
REVIEW: 106606
2012-10-22 13:03:36 +02:00
Albert Astals Cid c1add8acdc Merge remote-tracking branch 'origin/KDE/4.9' 2012-10-16 20:39:58 +02:00
Albert Astals Cid 5650efa667 Follow allow rules 2012-10-16 20:38:55 +02:00
Christian Holme 146369e3d2 Send word to selection clipboard on double click
BUGS: 306824
FIXED-IN: 4.9.3
2012-10-16 20:36:52 +02:00
Bogdan Cristea 7ce6990098 Separate settings in core and non core
Will make it easier to make separate apps based on the core in the future
Note this will most probably break your settings if you are not running a very up to date kdelibs (4.9 or 4.10)
so be careful on updating
REVIEW: 104947
2012-10-16 00:28:29 +02:00
Albert Astals Cid 1f2e2353b2 Small style changes 2012-10-15 20:21:43 +02:00
Jon Mease b395e742fc Support high precision QTabletEvents for creating annotations
REVIEW: 106816
2012-10-15 20:11:47 +02:00
Sandro Mani ec7b2e763d Make document scroll as necessary when in text selection mode
BUGS: 165744
FIXED-IN: 4.10.0
REVIEW: 106579
2012-09-28 17:57:03 +02:00
Albert Astals Cid ed02ecfb60 Remove the disable threading option
It was added ages ago when our threading code was not perfect, but should be top notch now so this makes not any sense
2012-09-25 21:18:10 +02:00
Tobias Koenig f70dc3c1e1 Fix visibility of VideoWidget on page change events
We have to differ between the initialization and the
'page entered' and 'page left' event.
This avoids that all VideoWidgets with poster image show up
on first slide or do no disappear when changing slide.
2012-09-21 11:20:53 +02:00
Fabio D'Urso c6f20bd1eb Killed ZoomFitText, not supported by Okular
Commit 02e7c0abfb says that it's "not yet
implemented", but that was KDE 4.0, before the "Trim margin" feature was
introduced.
2012-09-08 20:43:44 +02:00
Sandro Mani 636d4e1c75 Allow customization of scroll page keybindings
REVIEW: 106293
BUGS: 304291
FIXED-IN: 4.10.0
2012-09-05 22:12:11 +02:00
Mailson Menezes ceea13e108 Always have the correct viewport when zooming
Whenever the scrollbar value changes we request a new pixmap so we
always have an up to date viewport.
Unfortunately that can lead to unnecessary calls when zooming. That's
because the zoom event changes the value of each scrollbar but not all
at once. Instead one scrollbar value is changed after the other (leading
to two requests).
The problem here is that when the first request is made just one of the
scrollbars have its updated value while the other still carries the old
one. Previously that wasn't a big deal but now we depend on the correct
scrollbar values to get the visible viewport and thus request only the
visible tiles (and its whereabouts).
Without that change we're making requests to tiles that are not actually
visible and this only gets worse as the zoom level gets higher.
2012-09-03 13:14:20 -03:00
Sandro Mani 7d18d176bc When there is only one page, "Opposite pages" should have no effect
FIXED-IN: 4.10.0
BUGS: 305194
2012-08-30 01:03:16 +02:00
Sandro Mani 56dd5278d2 Fix Tools->review inconsistency when switching tool
BUGS: 304621
FIXED-IN: 4.9.1
(cherry picked from commit a2dd088ebd)
2012-08-27 21:01:17 +02:00