Commit graph

61 commits

Author SHA1 Message Date
Albert Astals Cid b9c40d709d Fix formatting after Laurent's commit
Please Laurent try to use MR when you do changes that may break our CI
like this one

CCMAIL: montel@kde.org
2020-10-23 22:48:44 +02:00
Laurent Montel 486e05b270 If include is define in .h remove it if it's defined in .cpp too (scripted) 2020-10-23 07:32:28 +02:00
Albert Astals Cid 19d98d6a74 Run clang-format
find . \( -name "*.cpp" -or -name "*.h"  -or -name "*.c"  -or -name "*.cc" \) -exec clang-format -i {} \;

If you reached this file doing a git blame, please see README.clang-format (added 2 commits in the future of this one)
2020-07-11 09:17:33 +02:00
Albert Astals Cid 93540ac16d Enable most of clazy level2 2020-02-21 14:57:48 +01:00
Albert Astals Cid 6ddb7e6cc9 CI: Enable clazy qhash-namespace 2020-02-19 23:44:41 +01:00
Albert Astals Cid b001ea2019 CI: Enable a bunch of bugprone- clang-tidy warnings 2019-12-24 10:18:16 +00:00
Albert Astals Cid 0a2287be19 CI: Enable two readability clang-tidy checks
Use jq to filter compile_commands.json to not include the compilation of
autogenerated files, we don't want to check those

Also filter out the synctex folder, since that is imported code
2019-12-23 12:06:49 +01:00
Albert Astals Cid 27b76ee7c0 TextDocumentGenerator: Support links that span more than one line
Summary:
If a link spans more than one line we need one rect for each of the lines

BUGS: 403247

Subscribers: okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D18303
2019-01-28 22:09:30 +01:00
Albert Astals Cid 4fb7582093 Obey rule-of-three in NormalizedPoint and NormalizedRect
I.e. make sure they have destructor, copy constructor and asignment
operator

They don't really need them since it's plain data that can be copied
with the defaul implementations (which is actually what i am using) but
since we had some of them implemented and some not, clazy was
complaining that this is generally a bad idea, so implement them all
2019-01-10 00:44:41 +01:00
Yuri Chornoivan c04ca1fa96 Fix minor EBN issues 2018-08-31 12:23:45 +03:00
Kevin Funk a53a2402ca clang-tidy: modernize-use-nullptr run
Semi-ACK'd by Albert :)
2017-09-06 00:19:48 +02:00
Gleb Popov b8d22401f2 Implement qHash() for Okular::NormalizedRect. 2015-10-17 15:10:16 +03:00
Frederik Gladhorn 6c602bf0e7 Use categorized logging even more 2014-09-16 23:38:25 +02:00
Frederik Gladhorn 9d89739972 Use categorized logging 2014-09-16 23:24:36 +02:00
Frederik Gladhorn 83d3f1f6b7 Revert "Some more kDebug->qDebug"
Seems like kDebug doesn't spam the user, so this needs to use qCDebug.

This reverts commit 34fbdf8c85.
2014-09-11 02:03:46 +02:00
Frederik Gladhorn 34fbdf8c85 Some more kDebug->qDebug 2014-09-09 18:17:36 +02:00
Peter Grasch 4d4dd68ca2 Fix usability issues with selecting annotations
REVIEW: 109627
2013-06-23 19:22:21 +02:00
Fabio D'Urso 3656d8ea47 Force minimum AnnotationObjectRect size
So that it's easier to select thin horizontal/vertical lines
2012-12-16 21:05:15 +01:00
Jan Binder aa6ed8afc0 Replace deprecated QMatrix by QTransform
REVIEW: 105737
2012-09-08 17:06:02 +02:00
Mohammad Mahfuzur Rahman Mamun f14a8502dd remove some problems from makeWord function in textPage 2011-07-02 21:24:50 +06:00
Albert Astals Cid 81d255bafb add a function that returns the center of a given normalized rect
svn path=/trunk/KDE/kdegraphics/okular/; revision=1048191
2009-11-12 21:45:35 +00:00
Pino Toscano 6d0241e5d2 add functions to get the nearest object rect to a point in a page, and return its distance, and the accessor functions for object rects
based on an patch by Luigi Toscano, thanks!
CCMAIL: luigi.toscano@tiscali.it

svn path=/trunk/KDE/kdegraphics/okular/; revision=943099
2009-03-23 12:05:00 +00:00
Albert Astals Cid d40bec4671 Normalize the rect, after all is called normalized rect, no?
Fixes first pdf of bug 161327

Pino, should i backport this to 4.1.4?

CCBUG: 161327

svn path=/trunk/KDE/kdegraphics/okular/; revision=902306
2008-12-28 01:20:43 +00:00
Pino Toscano bd833bdd5c hopefully make it compile and work also where qreal is not double but float
svn path=/trunk/KDE/kdegraphics/okular/; revision=837842
2008-07-25 20:51:42 +00:00
Pino Toscano d650603340 add operator& (intersection) for NormalizedRect
original patch by kde2eran@tromer.org, thanks!

CCMAIL: kde2eran@tromer.org

svn path=/trunk/KDE/kdegraphics/okular/; revision=809403
2008-05-18 21:08:31 +00:00
Pino Toscano 1f43811f61 redirect all the debug output of core to the debug area
svn path=/trunk/KDE/kdegraphics/okular/; revision=763941
2008-01-20 16:39:21 +00:00
Pino Toscano 97fa2243ea don't do the merge when turning a regular area rect into an highlight area rect
svn path=/trunk/KDE/kdegraphics/okular/; revision=708740
2007-09-05 14:51:40 +00:00
Pino Toscano 5150419e81 adapt the debug stuff to the new kdebug way:
- make the output looking more or less like before (using nospace() or removing the spaces)
- remove endl and '\n' at the end of debug outputs
- fixing the QDebug operator<<'s around
- isolate the debug area number of the core into a separate header, and apply it instead of the numbers found in textpage.cpp

svn path=/trunk/KDE/kdegraphics/okular/; revision=694667
2007-07-31 10:19:48 +00:00
Thiago Macieira 000dc825e3 Use QDebug instead of kdbgstream
svn path=/trunk/KDE/kdegraphics/okular/; revision=694533
2007-07-30 23:58:04 +00:00
Pino Toscano aa8155f8ed decouple the transformation applying and resetting methods, and reset the transformation when setting a new bonding rect or translating
svn path=/trunk/KDE/kdegraphics/okular/; revision=691056
2007-07-22 20:49:27 +00:00
Pino Toscano fbe8dbf108 promote RegularAreaRect from a typedef to a class, a bit more easy to eventually expand in the future
svn path=/trunk/KDE/kdegraphics/okular/; revision=686281
2007-07-10 23:15:14 +00:00
Pino Toscano 1eb435cddb remove the kdebug.h inclusion in area.h
svn path=/trunk/KDE/kdegraphics/okular/; revision=661410
2007-05-05 13:50:44 +00:00
Pino Toscano 94355bce65 move the transform() hierarchy within the private class; allow AnnotationObjectRect to use the trasform() stuff
svn path=/trunk/KDE/kdegraphics/okular/; revision=661202
2007-05-04 20:45:45 +00:00
Pino Toscano 5f21b15d99 Link -> Action renaming.
Step #2: Link -> Action for the action hierarchy, and for the ObjectRect type.

svn path=/trunk/KDE/kdegraphics/okular/; revision=656140
2007-04-20 12:37:12 +00:00
Pino Toscano f3e484082d Link -> Action renaming.
Step #1: link.(cpp|h) -> action.(cpp|h)

svn path=/trunk/KDE/kdegraphics/okular/; revision=656123
2007-04-20 11:26:05 +00:00
Albert Astals Cid 0d47b62715 krazy include order issues
svn path=/trunk/KDE/kdegraphics/okular/; revision=655893
2007-04-19 18:30:20 +00:00
Pino Toscano 37b5d0f3cc handy method
svn path=/trunk/playground/graphics/okular/; revision=629174
2007-02-01 18:31:45 +00:00
Pino Toscano 328958171d use the right include
svn path=/trunk/playground/graphics/okular/; revision=619077
2007-01-02 17:50:24 +00:00
Tobias Koenig 14ea3ab2ef Further documentation and API cleanups
svn path=/trunk/playground/graphics/okular/; revision=619054
2007-01-02 17:05:49 +00:00
Pino Toscano d5f99995dd add handy debug operators for NormalizedPoint and NormalizedRect
svn path=/trunk/playground/graphics/okular/; revision=618237
2006-12-31 17:52:24 +00:00
Pino Toscano dff36b98f8 simplify RegularAreaRect by avoiding the usage of pointers, as they don't give benefits anyway.
Fixing also the text extraction when using the rectangular selection across two or more pages.

svn path=/trunk/playground/graphics/okular/; revision=616264
2006-12-24 18:19:18 +00:00
Pino Toscano 2f1aa08ac6 move the annotation boundary calculation to AnnotationUtils
svn path=/trunk/playground/graphics/okular/; revision=606811
2006-11-21 21:35:45 +00:00
Tobias Koenig a490cc0cd7 Add the following functionality:
* Bring QPixmap* back to make Albert happy ;)
 * Store only one QPixmap per page/size and rotate it directly
 * Rotate ObjectRects (boundary)
 * Rotate Annotations (point coordinates)
 * Don't reload pixmaps, ObjectRects and annotations on rotation

svn path=/trunk/playground/graphics/okular/; revision=606371
2006-11-20 07:53:32 +00:00
Pino Toscano 274469dae8 Almost complete support for inverse search within okular.
THe system generally works; what is missing is a good activating strategy (added in TODO - our usability expert is working on that), and a GUI to configure the editor.
The DVI backend was adapted to use this new feature.
(The PDF backend will use it soon.)

svn path=/trunk/playground/graphics/okular/; revision=605708
2006-11-17 22:15:15 +00:00
Pino Toscano d6fd44e1ed forward declaration
svn path=/trunk/playground/graphics/okular/; revision=599828
2006-10-28 18:03:33 +00:00
Pino Toscano 08877db01b const&
svn path=/trunk/playground/graphics/okular/; revision=594961
2006-10-12 22:04:26 +00:00
Pino Toscano c42348edaa improve the HighlightAreaRect ctor
svn path=/trunk/playground/graphics/okular/; revision=594957
2006-10-12 21:55:32 +00:00
Pino Toscano 12827bf0eb re-write to avoid using a temporary object
svn path=/trunk/playground/graphics/okular/; revision=594953
2006-10-12 21:43:55 +00:00
Pino Toscano 42310e184c Restructuring a bit how the text-editor-like selection works:
* putting it in an own view mode
* associating the selection to every page
* using a better algorithm to calculate the selection, even in a page range
* moving its drawing from the page view to the page painter, so it's possibile to draw it just like it's done with eg annotations

Other changes (more or less related):
* moved the annotation popup to a better place, so it won't interfere with annotation drawing
* commented some debug code in TextPage

svn path=/trunk/playground/graphics/okular/; revision=588795
2006-09-26 22:22:01 +00:00
Tobias Koenig df7d144c10 Moved all classes in core/ into the 'Okular' namespace and removed
nearly all references to kpdf (knewstuff still missing).

svn path=/trunk/playground/graphics/okular/; revision=586993
2006-09-21 08:45:36 +00:00