office/okular
office/okular
1
0
Fork 0
mirror of https://invent.kde.org/graphics/okular synced 2024-08-27 19:50:27 +00:00
Code Issues Packages Projects Releases Wiki Activity
10669 commits 139 branches 358 tags 110 MiB
Commit graph

70 commits

Author SHA1 Message Date
Nicolas Fella f7b1b3b032 Remove unused caller arg from KBookmarkManager::changed 2024-01-03 21:02:38 +01:00
Sune Vuorela 2fad5243ab Remove setUpdate call; it doesn't do anything 
And it defaults to true
 2024-01-03 19:49:53 +00:00
Sune Vuorela 792425fc77 s/qAsConst/std::as_const/ 
We now definitely has std::as_const available and Qt has started nagging
about converting to std::as_const.

Implementation is the same for both functions, and qAsConst was a
stop-gap measure until std::as_const was sufficiently available.
 2023-12-19 11:46:24 +00:00
Carl Schwan 514640923b Port to newer KBookmark API 2023-12-18 22:56:22 +00:00
Nicolas Fella 9bf396ee7e Add missing KBookmarkOwner include 2022-10-15 22:52:36 +02:00
Albert Astals Cid ba35bbd9e6 emit -> Q_EMIT 
A future ECM is going to force that on us, so do it early
 2022-03-19 10:58:47 +00:00
Volker Krause 50d0703ae0 Enable readability-braces-around-statements 2022-03-09 23:29:56 +01:00
Albert Astals Cid 0c659a5466 clang-tidy: Enable google-explicit-constructor 2021-08-29 08:52:35 +00:00
Alexander Lohnau 2f193a63de Convert license headers to SPDX 2021-06-10 08:11:56 +00:00
Albert Astals Cid caa351c723 Bookmarks: Resolve symlinks before using an url 
If a symlink points to another file, we should use that file as
canonical source for bookmarks, it doesn't make sense to have two
different sets of bookmarks for two paths that are essentially the same
file

BUGS: 424340
 2020-08-07 22:34:30 +00:00
Albert Astals Cid 19d98d6a74 Run clang-format 
find . \( -name "*.cpp" -or -name "*.h"  -or -name "*.c"  -or -name "*.cc" \) -exec clang-format -i {} \;

If you reached this file doing a git blame, please see README.clang-format (added 2 commits in the future of this one)
 2020-07-11 09:17:33 +02:00
Laurent Montel 516fb89d94 Use camelcase include. (scripted) 2020-07-08 13:54:37 +02:00
Albert Astals Cid 46d1ba0e20 Enable clazy missing-qobject-macro 2020-02-21 17:09:46 +01:00
Albert Astals Cid 6d0d61c2ad Enable clazy copyable-polymorphic 2020-02-21 17:09:43 +01:00
Albert Astals Cid 0a2287be19 CI: Enable two readability clang-tidy checks 
Use jq to filter compile_commands.json to not include the compilation of
autogenerated files, we don't want to check those

Also filter out the synctex folder, since that is imported code
 2019-12-23 12:06:49 +01:00
Albert Astals Cid c549acaab0 Move the Q_PRIVATE_SLOTS to lambda connections 
Some of the invokeMethods with a queued connection get changed with a
QTimer::SingleShot with 0 which has the same behaviour
 2019-12-20 16:42:58 +01:00
Ahmad Samir ccf3a384c3 [core/*] replace foreach, deprecated, with range-for 
The code compiles and okular seems to load and work as before, all unit
tests pass except (parttest and epubgeneratortest, but they fail on master
too).
 2019-12-09 13:16:55 +00:00
Laurent Montel 5a3a49c310 Port qSort to std::sort 2019-03-12 13:13:53 +01:00
Kevin Funk a53a2402ca clang-tidy: modernize-use-nullptr run 
Semi-ACK'd by Albert :)
 2017-09-06 00:19:48 +02:00
Albert Vaca 3c93b2523e Added missing overrides found by clang-tidy 2016-10-29 17:07:10 +02:00
Martin T. H. Sandsmark f05d42eac3 core: Fix build without implicit cast to/from ascii 
See previous commits for details.
 2016-07-11 22:07:57 +02:00
Montel Laurent 466eb79615 Use QStringLiteral 2015-10-29 13:37:11 +01:00
Lukáš Tinkl fd6a35486e port KUrl -> QUrl 2015-01-29 20:55:57 +01:00
Montel Laurent 17b7049c69 Fix includes 2014-10-08 13:48:01 +02:00
Montel Laurent 08013f87d0 Port to QStandardPaths 2014-10-07 13:21:58 +02:00
Arnold Dumas f8f90b15b3 Port away from KGlobal::caption(). 2014-09-26 20:04:00 +02:00
Frederik Gladhorn 6c602bf0e7 Use categorized logging even more 2014-09-16 23:38:25 +02:00
Frederik Gladhorn 83d3f1f6b7 Revert "Some more kDebug->qDebug" 
Seems like kDebug doesn't spam the user, so this needs to use qCDebug.

This reverts commit 34fbdf8c85.
 2014-09-11 02:03:46 +02:00
Frederik Gladhorn 34fbdf8c85 Some more kDebug->qDebug 2014-09-09 18:17:36 +02:00
Vishesh Handa 46cf7e46a5 Port away from KUrl::List 2014-08-13 13:07:44 +02:00
Frederik Gladhorn c7e003d7bc Port to QCommandLineParser 2014-08-09 13:27:12 +02:00
Frederik Gladhorn 0ba233788c Use moc include style dictated by automoc 
While it's generally not a great idea to include moc files at least this
compiles.
 2014-08-09 00:21:03 +02:00
Frederik Gladhorn d16ac66ab3 Fix some QUrl usage 2014-08-08 02:00:17 +02:00
Frederik Gladhorn 75031eee7e Fix includes 2014-08-08 01:59:55 +02:00
Albert Astals Cid 541650a4f4 Remove the concept of observer/view id 
Just use the pointer as id :-)

This is BIC and SIC, increase the soversion now to makes sure we don't forget in the future

Patch based in an earlier patch by Bogdan Cristea <cristeab@gmail.com>
REVIEW: 109115
 2013-02-24 23:01:02 +01:00
Fabio D'Urso 9a11294b12 Sort bookmarks from the same page in viewport order 2012-06-05 00:49:16 +02:00
David Faure dc2f2d36aa Fix compilation with strict iterators 2012-03-27 13:25:12 +02:00
Mailson Menezes bd9087f20a Remember position on the page in bookmark 
IOW accept more than one bookmark per page
BUGS: 157198
REVIEW: 104365
 2012-03-26 20:01:01 +02:00
Albert Astals Cid 3e3a504d3c Allow the renaming of bookmark "parent" items (i.e. file names) 
Patch heavily inspired on a patch by Constantin Serban-Radoi <costashsrc@gmail.com>
 2012-03-08 23:26:44 +01:00
Albert Astals Cid 405bd75a1a add a property with the page number 
deliverately not documented since we don't want others to use it
 2011-10-26 00:10:42 +02:00
Albert Astals Cid 880dae2e19 Add a way to rename the current page bookmark from the menu 
Comes with some api additions to bookmarkmanager
 2011-10-25 22:21:22 +02:00
Montel Laurent f9f65979f5 Normalize signals/slots 2011-07-31 21:22:04 +02:00
Laurent Montel a86bbe9053 Use QLatin1String 
svn path=/trunk/KDE/kdegraphics/okular/; revision=1178207
 2010-09-22 11:52:46 +00:00
Pino Toscano 45e62fa320 make sure actionsForUrl() returns actions sorted by page number 
CCBUG: 205952

svn path=/trunk/KDE/kdegraphics/okular/; revision=1129512
 2010-05-22 17:44:26 +00:00
Albert Astals Cid 4a1d8bb025 Do not use the title to store the url because it will get mangled by KBoomark::fullText, use the url field 
CCMAIL: 229141

svn path=/trunk/KDE/kdegraphics/okular/; revision=1108063
 2010-03-27 18:00:48 +00:00
Pino Toscano c3f75f13c2 add a function to remove a list of bookmark belonging to the specified url 
svn path=/trunk/KDE/kdegraphics/okular/; revision=1072132
 2010-01-09 13:13:43 +00:00
Christian Ehrlicher 9e2f6edcf5 KUrl::path() -> KUrl::toLocalFile() 
svn path=/trunk/KDE/kdegraphics/okular/; revision=1071713
 2010-01-08 15:29:38 +00:00
Pino Toscano aa84e31316 Change the saving strategy for bookmarks: instead of saving them manually or at closing, save them after each action. 
This should avoid any bookmark loss due to premature crash or similar abnormal closing.
BUG: 157246
BUG: 213206
Also, the above change triggers the D-Bus synchronisation of the internal bookmark manager of the various Okular instances;
react to those changes properly by updating the own info (because of the changes in the bookmark manager of another instance).
BUG: 216239

On the technical note, keep the cache of known file just with the bookmark address instead of the group itself
(which gets changed behind our back).

svn path=/trunk/KDE/kdegraphics/okular/; revision=1066286
 2009-12-26 16:57:09 +00:00
Pino Toscano 3b905e3cf4 undefine the internal macros at the end 
svn path=/trunk/KDE/kdegraphics/okular/; revision=908738
 2009-01-10 11:32:54 +00:00
Laurent Montel c2fc9836e8 Fix iterator 
svn path=/trunk/KDE/kdegraphics/okular/; revision=882957
 2008-11-11 18:48:40 +00:00