Commit graph

6489 commits

Author SHA1 Message Date
Fabio D'Urso 8e8c7a40b3 Invalidate saved data (viewport, expanded TOC nodes) when reload is canceled
So that next time slotDoFileDirty() is called, it will save data again, instead
of keeping data from the old reload attempt.
2013-06-08 17:27:17 +02:00
Fabio D'Urso 80ebb46d36 Don't attempt to restore old TOCModel if it hasn't been actually saved
Because if it hasn't been saved (54b4a20e07)
this results in m_model == 0, which makes us crash.
2013-06-08 17:27:17 +02:00
Fabio D'Urso 77a71a021a Test that Okular doesn't crash after a canceled reload
This would have caught the crash I'm going to fix in the next patch
2013-06-08 17:27:17 +02:00
Fabio D'Urso 889c942909 Test that we don't crash if we open the Configure backends dialog twice
This would have caught the issue fixed in 3dd3a000db
2013-06-08 16:54:56 +02:00
Fabio D'Urso 3c7d61fc24 Removed TextDocumentSettingsWidget::font()
Generators can query the font via generalSettings()->font()
2013-06-07 00:45:47 +02:00
Fabio D'Urso a79351212d Removed TextDocumentGenerator::generalSettingsWidget()
Which is now useless because with the previous patch
TextDocumentGenerator no longer caches the widget.
2013-06-07 00:44:56 +02:00
Fabio D'Urso 3dd3a000db Don't crash if Configure Backends is opened again after it's been closed 2013-06-07 00:26:05 +02:00
l10n daemon script 8f1b2b7281 SVN_SILENT made messages (.desktop file) 2013-06-05 04:52:43 +00:00
Jon Mease b7ce9114c5 Undo support for PDF forms
Together with the already commited support for undo in annotations fixes 177501
BUGS: 177501
REVIEW: 110589
FIXED-IN: 4.11.0
2013-06-03 22:46:41 +02:00
Yuri Chornoivan 8d98819184 Add the new option to open configuration page for annotations to documentation
Signed-off-by: Yuri Chornoivan <yurchor@ukr.net>
2013-05-30 19:30:38 +03:00
l10n daemon script 99a74074f4 SVN_SILENT made messages (.desktop file) 2013-05-30 04:28:22 +00:00
l10n daemon script 9a18084840 SVN_SILENT made messages (.desktop file) 2013-05-29 02:51:45 +00:00
Fabio D'Urso 5860fc89c5 Added shortcut to annotation config panel as review toolbar's context menu 2013-05-28 23:55:10 +02:00
Fabio D'Urso c3f7fd525e Don't reuse KConfigDialogs
Because a cached dialog stays parented to the initial part, which might
not be the one used to open it.
This is especially visible now that we support more than one window per
okular process.

For example:
 - User initially opens a dialog from window A
      -> This dialog gets cached as child of A's PageView. This implies that
         clicking on the dialog also brings window A to foreground.
 - User re-opens the dialog from a different window B
      -> The dialog is still a child of A's PageView, therefore clicking on the
         dialog's frame brings A to the foreground, and B to the background.
2013-05-28 23:44:56 +02:00
Fabio D'Urso 84d7eae067 Make KConfigDialogs application-modal (instead of window-modal) 2013-05-28 23:44:55 +02:00
Fabio D'Urso 4526dd2fd0 Make all parts receive config change notifications
Instead of listening on KConfigDialog's signals, this patch makes parts
listen on Okular::Settings::self()'s configChanged() signal.

Unlike KConfigDialogs, Okular::Settings::self() is unique and never
changes during the process lifetime, and therefore:
 - A part can connect during initialization and receive notifications,
   without depeding on KConfigDialog objects (which might be instanced
   or deleted by a different part).
 - The connection now survives deletion of the KConfigDialog.
2013-05-28 23:44:55 +02:00
Albert Astals Cid ccd889228e Prepare for 0.16.4 2013-05-28 20:17:31 +02:00
Albert Astals Cid 0fa9232f78 Do compressed checks based on mime inheritance
Instead of using a hardcoded map
BUGS: 320195
FIXED-IN: 4.10.4
2013-05-27 23:34:58 +02:00
Albert Astals Cid d8133a173c Do compressed checks based on mime inheritance
Instead of using a hardcoded map
BUGS: 320195
FIXED-IN: 4.10.4
2013-05-27 23:33:34 +02:00
Fabio D'Urso bc4965f936 Fixed fuzzy detection of coord equality in PolyLine engine
(1,0) is not the same as (0,1)
2013-05-24 18:54:26 +02:00
Fabio D'Urso ae64a4ba48 Annotation tool configuration: open edit window back on itemDoubleClick
Otherwise it's impossible to select items if itemActivated is configured
to be triggered by single-clicks.
This reverts f1d5638dca
2013-05-24 17:51:49 +02:00
Yuri Chornoivan 2a31087ac1 Fix my typos 2013-05-24 17:21:01 +03:00
Yuri Chornoivan b7a1c9bc00 REVIEW: 110599
A short documentation of Annotations configuration page
2013-05-23 21:41:33 +03:00
Burkhard Lück 26e036d1c1 add anchor for help call to open the configuration chapter when using help action in the onfiguration dialog 2013-05-23 10:06:09 +02:00
Albert Astals Cid f8a511a5f8 Small tweak to the UI 2013-05-22 00:01:02 +02:00
Albert Astals Cid 4884a024ff Merge remote-tracking branch 'origin/configurable-review-tools' 2013-05-21 23:29:30 +02:00
l10n daemon script b5a0efde37 SVN_SILENT made messages (.desktop file) 2013-05-21 11:09:57 +00:00
Fabio D'Urso edb5fc3275 Re-add some kWarnings about missing/invalid tools.xml file 2013-05-21 12:48:48 +02:00
Fabio D'Urso d3a6c9100c WidgetAnnotTools: Add edit button 2013-05-20 20:29:14 +02:00
Fabio D'Urso c8bcee597b WidgetAnnotTools: Tidy up slots 2013-05-20 20:29:14 +02:00
Fabio D'Urso 9e7cf9ae4b Merge remote-tracking branch 'origin/master' into configurable-review-tools 2013-05-20 20:28:49 +02:00
Albert Astals Cid 446a636abf Merge remote-tracking branch 'origin/KDE/4.10' 2013-05-20 18:22:56 +02:00
Albert Astals Cid 4e05cc2526 Fix wrong check
Parker messed up the logic that force it to be in text selection mode
to be on non text selecion mode when doing an unrelated change.

As the "bug" as showed we can selectAll in non text selection mode as well
so remove the check altogether

BUGS: 159276, 319554
FIXED-IN: 4.10.4
2013-05-20 18:15:55 +02:00
Fabio D'Urso 923698caab Change texts I forgot to change in 35d481e783 2013-05-20 15:01:50 +02:00
Yuri Chornoivan fb8cef1b89 Fix my typos 2013-05-20 08:32:13 +03:00
Yuri Chornoivan 3842827b28 Add missing comma 2013-05-19 21:16:32 +03:00
Yuri Chornoivan 8968636f32 Add description of the new configuration pages for backends, update screenshot 2013-05-19 14:23:53 +03:00
Yuri Chornoivan c32b130342 Some i18n fixes 2013-05-19 10:59:43 +03:00
Fabio D'Urso c1bf817e75 Use a enum instead of strings to identify combobox entries 2013-05-18 23:43:12 +02:00
Fabio D'Urso b49db982ea Make two helper inline functions static 2013-05-18 23:43:04 +02:00
Fabio D'Urso c6989bccce Fix comment 2013-05-18 22:36:27 +02:00
Fabio D'Urso f1d5638dca Connect to a better signal 2013-05-18 22:36:27 +02:00
Fabio D'Urso 6be4155a98 Moved AnnotationTools config option under the Reviews group 2013-05-18 19:35:46 +02:00
Fabio D'Urso 14703512b6 Merge remote-tracking branch 'origin/master' into configurable-review-tools 2013-05-18 19:34:37 +02:00
Azat Khuzhin f30c8def7b Added missing core/textdocumentsettings_p.h 2013-05-18 17:44:11 +02:00
Fabio D'Urso e27182f113 Set clicked back to false when the creation of a PickPoint annotation is completed
So that the hoverIcon is not shown above the newly created annotation.
This was especially visible if the creation of the annotation triggers a
message box warning, because one could see both the annotation and the
hover icon as long as the warning wasn't closed.
2013-05-18 17:16:41 +02:00
Fabio D'Urso fded55268d Show stamp preview in stamp tool icon
Note that if a low-res 16x16 version is available, it is shown instead
of the 64x64 version actually used by PagePainter.
e.g. try with the default stamp "Okular"
2013-05-18 17:16:40 +02:00
Fabio D'Urso 871f230aa6 Fixed Inplace annotations' layout in PagePainter
The bounding box was incorrectly calculated unless the zoom was at 100%.
It caused word wrapping and text alignment errors.
2013-05-18 17:16:34 +02:00
Albert Astals Cid aa9b2668c9 prepend okular_ to the config gile names 2013-05-18 16:16:09 +02:00
Albert Astals Cid e11d760de8 And now fix the fix 2013-05-18 16:06:51 +02:00