f9841b0f8a and e0f45add55
They break the windows build, which shows there's something defenitely
fishy going on with the current code, but oh well, someone with more
time needs to figure out a proper solution
It was causing problems (Windows build fails) now that we enabled -Wweak-vtables (and
probably before didn't work that much before, guessing that's why we had that if (doc)
in openFile)
This is the simplest solution, invokeMethod is not great but we already
use it, so it's not too terrible
The openDocument function was unused so remove it.
The other two solutions are:
* Make KDocumentViewer be part of okularcore and then link the
okularcore to the okular binary, not nice
* Make another dynamic library that just contains the KDocumentViewer
class, but i'd rather not add yet another library we have to install
and take care of
Read https://stackoverflow.com/a/23749273/11956287 for a full
explanation, but basically this is important for headers like the
interfaces/ and kdocumentviewer.h that are supposed to be used by third
partyies where it may happen that wrong things happen because the whole
class is inline in a header
For the classes that are defined in the .cpp or are not installed
headers this would not be necessary but it's not so hard to add a few
default defined destructors, so do that :)
find . \( -name "*.cpp" -or -name "*.h" -or -name "*.c" -or -name "*.cc" \) -exec clang-format -i {} \;
If you reached this file doing a git blame, please see README.clang-format (added 2 commits in the future of this one)
-p, --page <page> : to select the startup page
--presentation : to start directly in presentation mode
implementing also KPDF wishes #134115 and #137905.
svn path=/trunk/playground/graphics/okular/; revision=619681
