Commit graph

9124 commits

Author SHA1 Message Date
Albert Astals Cid
265b85fd6e Remove unneded deprecated KConfigDialogManager::changedMap calls
Both WidgetDrawingTools and WidgetAnnotTools have a NOTIFY changed USER true property so that's what is used anyway
2020-09-30 16:09:56 +00:00
Albert Astals Cid
de78c666ad Port away from deprecated KAboutData::fromPluginMetaData 2020-09-30 16:09:56 +00:00
Albert Astals Cid
8ab379e178 Part away from deprecated QProcess::finished(int) 2020-09-30 16:09:56 +00:00
Albert Astals Cid
e2ece3793e Port use of deprecated QModelIndex::child 2020-09-30 16:09:56 +00:00
Simone Gaiarin
837a9c1f52 Use the term "Annotations" everywhere in place of "Reviews"
BUG: 186797
FIXED-IN: 20.12.0
2020-09-30 08:24:57 +02:00
l10n daemon script
5c0e72d779 GIT_SILENT made messages (after extraction) 2020-09-30 08:18:59 +02:00
l10n daemon script
421f20e669 GIT_SILENT made messages (after extraction) 2020-09-30 02:14:44 +02:00
Nate Graham
d78e2ff9e7 Merge branch 'release/20.08' into master 2020-09-29 09:36:56 -06:00
Kishore Gopalakrishnan
740318df90 Re-add support for pageup/pagedown overlap. 2020-09-29 11:03:48 +05:30
Luigi Toscano
2186324681 Improve the error message when export a certificate
Do not use the exclamation mark as suggested by the HIG
(https://hig.kde.org/style/writing/wording.html), and
reword the whole message as suggested by Albert.
2020-09-26 23:06:31 +02:00
Antoni Bella Pérez
a62666cfad [doc] Applied changes for:
URL changed from http to https
Use more entities
Remove 'latex' entity from header, already included to general.entities
2020-09-25 20:56:10 +02:00
Kezi Olio
bdb2df773d Fix forms when inertially scrolling
`setViewport` automatically adds an item to the history if it finds that it
moved for more than a page, which we don't want to do when automatically
scrolling, as with inertial scrolling.

This commit adds a new function `setViewportWithHistory()` which takes an
argument to optionally avoid preserving history. This avoids breaking ABI.
The new history-less functionality is used when inertially scrolling.

BUG: 421354
FIXED-IN: 1.11.2
2020-09-25 15:41:23 +00:00
l10n daemon script
601e96037c SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-09-25 09:54:54 +02:00
l10n daemon script
21647201c2 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-09-25 06:16:02 +02:00
Albert Astals Cid
1f187211bc Remove CI workaround 2020-09-24 19:35:36 +02:00
Nate Graham
122528d3fe Add option to disable smooth scrolling
Even though the animated smooth scrolling transitions are now affected
by the global animation speed setting in Plasma, this is not totally
satisfactory for the full pool of people who hate smooth scrolling, as
it does not address the cases of people using Okular outside of Plasma
or people who generally want animations but just not in Okular's
scrolling implementation.

Accordingly, there is now a GUI option to disable smooth scrolling in
Okular's settings window.

BUG: 420755
FIXED-IN: 20.12
2020-09-24 13:43:54 +00:00
Albert Astals Cid
ceb8cf629d poppler: Convert Stamp annotations via C++
Instead of via the magic XML cycle of Poppler::AnnotationUtils::storeAnnotation + Okular::AnnotationUtils::createAnnotation
2020-09-24 07:42:52 +00:00
Albert Astals Cid
d13b18af32 poppler: Convert Caret annotations via C++
Instead of via the magic XML cycle of Poppler::AnnotationUtils::storeAnnotation + Okular::AnnotationUtils::createAnnotation
2020-09-24 07:42:52 +00:00
Albert Astals Cid
bfdd033bfb poppler: Convert Ink annotations via C++
Instead of via the magic XML cycle of Poppler::AnnotationUtils::storeAnnotation + Okular::AnnotationUtils::createAnnotation
2020-09-24 07:42:52 +00:00
Albert Astals Cid
a39708e71d Remove setTextIcon call that we already do at createAnnotationFromPopplerAnnotation 2020-09-24 07:42:52 +00:00
Albert Astals Cid
eed89aaef6 poppler: Convert Highlight annotations via C++
Instead of via the magic XML cycle of Poppler::AnnotationUtils::storeAnnotation + Okular::AnnotationUtils::createAnnotation
2020-09-24 07:42:52 +00:00
Albert Astals Cid
f533788637 poppler: Convert Geom annotations via C++
Instead of via the magic XML cycle of Poppler::AnnotationUtils::storeAnnotation + Okular::AnnotationUtils::createAnnotation
2020-09-24 07:42:51 +00:00
Rafael Sadowski
49c680fd0e Fix RTTI with clang
Clang's RTTI support don't work here, use qobject_cast<> to avoid
runtime crashes.
2020-09-23 18:43:43 +02:00
Albert Astals Cid
aabff9dbee Merge remote-tracking branch 'origin/release/20.08' into master 2020-09-22 09:08:53 +02:00
Albert Astals Cid
3f89246317 Show "Follow link" if right clicking over link and annotation
Unite handling of right click in mouse release event

Before we had handling on press -> show annot menu if annot
and in release -> show link menu if link or show the genericmenu if nothing

Now we do everything on release and do
show link and annot menu if both
show link menu if link
show annot menu if annot
show generic menu if nothing

It helps with the fact that you can't click on links if there's an
annotation on top, which is a bit of a pain but it makes sense since
annotations usually have more interaction than links, you can select,
move, etc. them

BUGS: 425291
2020-09-22 01:30:40 +02:00
Albert Astals Cid
9b86535312 AnnotationPopup: Add possibility of filling an outside menu 2020-09-22 01:30:40 +02:00
Albert Astals Cid
4e91ab85fd Rework how AnnotationPopup handles user choices
We use use connect with the action instead of checking the action
pointer after exec
2020-09-22 01:30:34 +02:00
Albert Astals Cid
40e890ef05 Move the i18n context where it matters
Adding context to "%1" means nothing, how else is "%1" going to be
translated whatever the context is? Put the context in the actual colors
2020-09-21 18:11:00 +02:00
Albert Astals Cid
dd80eb6673 Merge remote-tracking branch 'origin/release/20.08' into master 2020-09-21 11:04:19 +02:00
Albert Astals Cid
8eb0c0c56c Don't use i18n in static variables
It's wrong, we can't be 100% sure the translation file is loaded already, use
ki18n

And while at it, make \"Transparent\" translatable
2020-09-21 01:05:31 +02:00
Oliver Sander
cc3f2857e0 Add an autotest for bug 421159
Bug 421159 involves a combination of scrolling with the scroll bar
and the mouse wheel.  This patch adds an autotest for the bug,
to make sure it doesn't come back.
2020-09-20 21:27:39 +02:00
Albert Astals Cid
1a490056c8 Be more expressive on the "This document is signed" message 2020-09-20 09:54:12 +00:00
Nicolas Fella
43408594bb Port away from KIconLoader::loadMimeTypeIcon
It's about to be deprecated
2020-09-20 00:40:01 +02:00
Albert Astals Cid
4ee716096d We require Qt 5.12 now 2020-09-17 23:58:02 +02:00
Albert Astals Cid
ea5bf62189 We require KF 5.68 now, so cleanup some ifdefs 2020-09-17 23:57:58 +02:00
Laurent Montel
f7cc59b7dc Drop outdated QT_USE_FAST_OPERATOR_PLUS 2020-09-17 07:14:54 +02:00
Albert Astals Cid
7ccb475df8 Fix crash on files that have the same signature in more than 1 page
It happens with some official documents where they use the same
signature in all pages to make it clear all pages are signed/official

BUGS: 426467
2020-09-17 01:27:42 +02:00
Albert Astals Cid
56a23a803f CI: fix build_clazy_clang_tidy 2020-09-17 01:27:42 +02:00
Albert Astals Cid
9bf171a108 Fix crash on files that have the same signature in more than 1 page
It happens with some official documents where they use the same
signature in all pages to make it clear all pages are signed/official

BUGS: 426467
2020-09-16 21:42:23 +00:00
Albert Astals Cid
f1b29aca4f CI: fix build_clazy_clang_tidy 2020-09-16 19:46:08 +02:00
Nate Graham
290b070f05 Merge branch 'release/20.08' into master 2020-09-15 09:50:50 -06:00
Kezi Olio
a5be0149ec Restore mouse drag scrolling, so it starts immediately
QScroller uses a minimum drag distance before drag scrolling starts by default.
This sets the minimum distance to 0.0, to restore the original behavior of the Browse tool.

BUG: 420842
2020-09-15 14:11:30 +02:00
Pedro Arthur P. R. Duarte
e238f21bbb Fix dangling annotation tooltip 2020-09-14 23:02:15 +00:00
Nate Graham
21262ae22b Change scroll speed on the fly if the user changes it while Okular is open
This uses KConfigWatcher to listen for changes to the relevant config
value and update the speed dynamically, rather that just once when the
app is launched.
2020-09-14 17:02:37 +00:00
Nate Graham
2d6fafe255 Scale smooth scroll durations according to the global animation speed
Now people who don't like animations can set thenm to "Instant" globally
and smooth scrolling will be effectively disabled off in Okular.

There is no change in speed for people using the default global
animation duration.

BUG: 420755
FIXED-IN: 1.12.0
2020-09-14 17:02:37 +00:00
Nate Graham
37bb01c61d Define animated smooth scroll durations in a central location
This will make it easy to adjust the durations in the future.
2020-09-14 17:02:37 +00:00
Friedrich W. H. Kossebau
37bf29d57d Use ecm_setup_qtplugin_macro_names
Avoids all the explicit boilerplate needed, ensures the dependency on
the JSON file ia also set and allows simple export of the setup
in the installed CMake config file, so other projects importing
the config file have the respective CMake macros set as recommended.

Test Plan:
Still builds as before. Touch a plugin metadata JSON file now triggers a moc
rerun. CMake config file contains setup of variables.
2020-09-13 11:20:50 +02:00
Friedrich W. H. Kossebau
1784c1d0cb Use more nullptr instead of 0 2020-09-13 11:20:09 +02:00
Friedrich W. H. Kossebau
7d34808dd3 Remove unneeded moc include 2020-09-13 11:00:42 +02:00
Albert Astals Cid
4085181512 UDSEntry::insert -> UDSEntry::fastInsert
we're clearing the UDSEntry just before the inserts so it's safe to
assume we're not inserting something that was there already
2020-09-13 01:25:54 +02:00