Commit graph

9149 commits

Author SHA1 Message Date
Albert Astals Cid 9b86535312 AnnotationPopup: Add possibility of filling an outside menu 2020-09-22 01:30:40 +02:00
Albert Astals Cid 4e91ab85fd Rework how AnnotationPopup handles user choices
We use use connect with the action instead of checking the action
pointer after exec
2020-09-22 01:30:34 +02:00
Albert Astals Cid 40e890ef05 Move the i18n context where it matters
Adding context to "%1" means nothing, how else is "%1" going to be
translated whatever the context is? Put the context in the actual colors
2020-09-21 18:11:00 +02:00
Albert Astals Cid dd80eb6673 Merge remote-tracking branch 'origin/release/20.08' into master 2020-09-21 11:04:19 +02:00
Albert Astals Cid 8eb0c0c56c Don't use i18n in static variables
It's wrong, we can't be 100% sure the translation file is loaded already, use
ki18n

And while at it, make \"Transparent\" translatable
2020-09-21 01:05:31 +02:00
Oliver Sander cc3f2857e0 Add an autotest for bug 421159
Bug 421159 involves a combination of scrolling with the scroll bar
and the mouse wheel.  This patch adds an autotest for the bug,
to make sure it doesn't come back.
2020-09-20 21:27:39 +02:00
Albert Astals Cid 1a490056c8 Be more expressive on the "This document is signed" message 2020-09-20 09:54:12 +00:00
Nicolas Fella 43408594bb Port away from KIconLoader::loadMimeTypeIcon
It's about to be deprecated
2020-09-20 00:40:01 +02:00
Albert Astals Cid 4ee716096d We require Qt 5.12 now 2020-09-17 23:58:02 +02:00
Albert Astals Cid ea5bf62189 We require KF 5.68 now, so cleanup some ifdefs 2020-09-17 23:57:58 +02:00
Laurent Montel f7cc59b7dc Drop outdated QT_USE_FAST_OPERATOR_PLUS 2020-09-17 07:14:54 +02:00
Albert Astals Cid 7ccb475df8 Fix crash on files that have the same signature in more than 1 page
It happens with some official documents where they use the same
signature in all pages to make it clear all pages are signed/official

BUGS: 426467
2020-09-17 01:27:42 +02:00
Albert Astals Cid 56a23a803f CI: fix build_clazy_clang_tidy 2020-09-17 01:27:42 +02:00
Albert Astals Cid 9bf171a108 Fix crash on files that have the same signature in more than 1 page
It happens with some official documents where they use the same
signature in all pages to make it clear all pages are signed/official

BUGS: 426467
2020-09-16 21:42:23 +00:00
Albert Astals Cid f1b29aca4f CI: fix build_clazy_clang_tidy 2020-09-16 19:46:08 +02:00
Nate Graham 290b070f05 Merge branch 'release/20.08' into master 2020-09-15 09:50:50 -06:00
Kezi Olio a5be0149ec Restore mouse drag scrolling, so it starts immediately
QScroller uses a minimum drag distance before drag scrolling starts by default.
This sets the minimum distance to 0.0, to restore the original behavior of the Browse tool.

BUG: 420842
2020-09-15 14:11:30 +02:00
Pedro Arthur P. R. Duarte e238f21bbb Fix dangling annotation tooltip 2020-09-14 23:02:15 +00:00
Nate Graham 21262ae22b Change scroll speed on the fly if the user changes it while Okular is open
This uses KConfigWatcher to listen for changes to the relevant config
value and update the speed dynamically, rather that just once when the
app is launched.
2020-09-14 17:02:37 +00:00
Nate Graham 2d6fafe255 Scale smooth scroll durations according to the global animation speed
Now people who don't like animations can set thenm to "Instant" globally
and smooth scrolling will be effectively disabled off in Okular.

There is no change in speed for people using the default global
animation duration.

BUG: 420755
FIXED-IN: 1.12.0
2020-09-14 17:02:37 +00:00
Nate Graham 37bb01c61d Define animated smooth scroll durations in a central location
This will make it easy to adjust the durations in the future.
2020-09-14 17:02:37 +00:00
Friedrich W. H. Kossebau 37bf29d57d Use ecm_setup_qtplugin_macro_names
Avoids all the explicit boilerplate needed, ensures the dependency on
the JSON file ia also set and allows simple export of the setup
in the installed CMake config file, so other projects importing
the config file have the respective CMake macros set as recommended.

Test Plan:
Still builds as before. Touch a plugin metadata JSON file now triggers a moc
rerun. CMake config file contains setup of variables.
2020-09-13 11:20:50 +02:00
Friedrich W. H. Kossebau 1784c1d0cb Use more nullptr instead of 0 2020-09-13 11:20:09 +02:00
Friedrich W. H. Kossebau 7d34808dd3 Remove unneeded moc include 2020-09-13 11:00:42 +02:00
Albert Astals Cid 4085181512 UDSEntry::insert -> UDSEntry::fastInsert
we're clearing the UDSEntry just before the inserts so it's safe to
assume we're not inserting something that was there already
2020-09-13 01:25:54 +02:00
Albert Astals Cid 8a1bef81f8 Remove poppler 0.80 ifdefs since we require 0.86 now 2020-09-13 01:21:11 +02:00
Albert Astals Cid 6b08af754f Remove poppler 0.79 ifdefs since we require 0.86 now 2020-09-13 01:20:14 +02:00
Albert Astals Cid 4d12c257b2 Remove poppler 0.74 ifdefs since we require 0.86 now 2020-09-13 01:18:34 +02:00
Albert Astals Cid 9264723002 Remove poppler 0.73 ifdefs since we require 0.86 now
This actually fixes a mistake in SignatureFormTest::testSignatureForm
2020-09-13 01:16:27 +02:00
Albert Astals Cid e283da994b Remove poppler 0.69 ifdefs since we require 0.86 now 2020-09-13 01:12:53 +02:00
Albert Astals Cid eacb5eed8b Remove poppler 0.68 ifdefs since we require 0.86 now 2020-09-13 01:12:05 +02:00
Albert Astals Cid 7dce3389cb Remove poppler 0.65 ifdefs since we require 0.86 now 2020-09-13 01:11:08 +02:00
Albert Astals Cid c019a7e76c Remove poppler 0.64 ifdefs since we require 0.86 now 2020-09-13 01:10:10 +02:00
Albert Astals Cid bcd36d6374 Remove poppler 0.63 ifdefs since we require 0.86 now 2020-09-13 01:07:38 +02:00
Albert Astals Cid c17127b018 cmake: suggest-override is provided by ECM since 5.55 2020-09-13 01:04:16 +02:00
Albert Astals Cid e989200dcf Increase minimum supported versions to those provided by Ubuntu 20.04 2020-09-13 01:03:53 +02:00
Albert Astals Cid d5210db504 Change the version to be date based
As discussed on the Akademy meeting, it's just simpler to do this than
keep pretending 1.10 vs 1.9 have some kind of meaning :)
2020-09-11 16:27:26 +00:00
Thomas Friedrichsmeier 3fda3ba561 Fix build using MinGW 2020-09-11 16:24:44 +02:00
Nate Graham 114060ff53 Merge branch 'release/20.08' into master 2020-09-11 07:59:46 -06:00
Nate Graham c54c38f761 Re-add smooth scrolling for arrow key and mouse wheel scrolling
This is safe now that the animated transitions no longer block repeated
scroll actions during the animation.

This partially reverts 08d368c13b

BUG: 422041
BUG: 425850
FIXED-IN: 1.11.2
2020-09-11 07:59:19 -06:00
Oliver Sander 112b6a10cd Merge remote-tracking branch 'upstream/release/20.08' into master 2020-09-11 11:38:58 +02:00
Oliver Sander e62870b528 Replace call to deprecated method QStringList::toSet
As suggested in the deprecation warning, the call is replaced by
QSet(begin,end).
2020-09-11 10:48:47 +02:00
Kishore Gopalakrishnan e637e2ed51 Remove if statement that disables pgup/dn key handling while scrolling.
IDK why it's there, but this seems to fix bug 422050
2020-09-11 10:44:54 +05:30
Christoph Cullmann 25984bb2bb add missing export to class
BUG: 426358
2020-09-10 20:51:52 +02:00
Michael Weghorn b696d6dbfb Support '#page=<pagenum>' fragment to open at page <pagenum>
Support the '#page=<pagenum>' fragment to specify which page
to open the document at, in addition to the existing '#<pagenum>'
syntax.

For PDF, the '#page=<pagenum>' fragment is specified in RFC 8118,
section 3.

BUG: 406831
2020-09-10 13:30:00 +00:00
Albert Astals Cid 0fed884424 Add missing QStringLiteral 2020-09-10 13:17:58 +02:00
Albert Astals Cid 2697105462 Revert cbddcd3273
KJS and KWallet are indeed optional, that's what the ${optionalComponents} variable does
2020-09-09 14:13:09 +02:00
Simone Gaiarin 4e0c1690d2 Uniform the case of the 'Id' suffix in variable names 2020-09-07 12:47:05 +00:00
Pedro Arthur Pinheiro Rosa Duarte 5d947905f7 Remove artifact while navigating though pages
When the view is paged (ie, non continuous), and an annotation is
selected while the user navigate through pages, the annotation
selection will become an artifact in other pages. Besides that,
the annotation will still receive keystrokes (such as delete).

Steps to Reproduce:
 - Open a PDF file with Okular
 - Draw an ellipsis annotation in the document
 - Select the ellipsis
 - Change to the previous or next page
2020-09-07 05:56:28 +00:00
Albert Astals Cid 4da86fb8de Merge remote-tracking branch 'origin/release/20.08' into master 2020-09-06 12:11:49 +02:00