Commit graph

19 commits

Author SHA1 Message Date
Albert Astals Cid
968e9d6073 Enable clazy old-style-connect 2020-02-20 15:48:08 +01:00
Albert Astals Cid
78cf6bd910 CI: enable more modernize checks
Since unfortunately some of the autogenerated includes don't pass the
checks we do a trick of building out of source and then specifying the
.*/okular/.* path as the only includes we care about
2019-12-18 12:51:13 +01:00
Laurent Montel
cb691f70dc Fix some clazy warning
Summary: fix clazy warning

Reviewers: aacid

Reviewed By: aacid

Subscribers: nicolasfella, okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D20832
2019-05-27 08:02:57 +02:00
Albert Astals Cid
19b7e3c112 The work in this branch was sponsored by LiMux
give them some credit in the headers
2017-11-16 09:58:31 +01:00
Albert Astals Cid
ca5422d0e9 Implement swapBackingFile for the PDF backend
How does it work:
 * What it does is really closing and opening the file again through poppler
 * This means that things that are generated in "open" time like Page, Rects, Annotations, Forms need to be updated
	* For Page what we do is swap the PagePrivate so that other classes that hold Page* don't break
		* Since some parts of the PagePrivate can be reused, we move them in PagePrivate::adoptGeneratedContents
	* For all the commands in the undo stack we need to update the annotations/forms it refers to, added a new function to do that
	* The annotationmodel needs updating it's pointers
	* The widgets for the forms are reused and their form* updated
	* the widgets for the videos are recreased since videos don't really hold much content (you lose the playing status on save but i think that's acceptable)

TODO: Make this work for .okular files
TODO: For files with password we will need to reload the file, asking for the password again and thus losing the undo stack, warn the user
TODO: autotests
2017-10-26 15:30:44 +02:00
Albert Astals Cid
ba02656646 Make m_annowindows a set instead of a hash
Will make it for easier maintainance when we need to reuse the windows and annotation pointers change
2017-10-25 14:59:17 +02:00
Albert Astals Cid
191a37fb52 Q_DECL_OVERRIDE -> override 2017-03-02 20:39:24 +01:00
Martin T. H. Sandsmark
439ced872d Port away from signal/slot keyword
When building okular without kdelibs4support it apparently builds with
-DQT_NO_SIGNALS_SLOTS_KEYWORDS.
2016-07-11 19:34:08 +02:00
Montel Laurent
a8c13a9e1d Add Q_DECL_OVERRIDE 2015-08-04 15:07:22 +02:00
Jon Mease
78faf1e68f Add undo/redo support for annotations
REVIEW: 107442
2013-04-06 00:22:48 +02:00
Albert Astals Cid
b2dfb910e8 Small rework of AnnotWindow
* We do not keep them around any more time than needed (they are cheap to create)
 * AnnotWindow::slotsaveWindowText calls m_document->modifyPageAnnotation so
   edition of inline notes happens immediately
2012-01-17 23:46:37 +01:00
Niels Ole Salscheider
65153935d9 add LaTeX support to annotation window 2011-09-22 19:22:15 +02:00
Albert Astals Cid
0a514d630b Close the annot window on Esc keypress
svn path=/trunk/KDE/kdegraphics/okular/; revision=1202702
2010-12-01 22:46:30 +00:00
Pino Toscano
4b50e543d6 focus the text when showing an annotation popup
svn path=/trunk/KDE/kdegraphics/okular/; revision=935096
2009-03-04 14:30:42 +00:00
Pino Toscano
961b27e99c Properly apply, and reload when changed, the annotation info in the annotation window (color, modication date, etc).
svn path=/trunk/KDE/kdegraphics/okular/; revision=789344
2008-03-24 00:08:08 +00:00
Tobias Koenig
df7d144c10 Moved all classes in core/ into the 'Okular' namespace and removed
nearly all references to kpdf (knewstuff still missing).

svn path=/trunk/playground/graphics/okular/; revision=586993
2006-09-21 08:45:36 +00:00
Pino Toscano
dc2c0bef27 Rewrite almost completely the AnnotWindow so it uses less hacks and more Qt stuff; now it's a bit more clean
svn path=/trunk/playground/graphics/okular/; revision=585647
2006-09-17 16:09:10 +00:00
Pino Toscano
6c2ea7b63d replace the hard-coded close button with a standard one.
the whole widget needs more loving, though.

svn path=/trunk/playground/graphics/okular/; revision=585241
2006-09-16 17:06:56 +00:00
Chu Xiaodong
9c575a91d3 replace embedded annotation dialog with annot window, child of PageView
svn path=/trunk/playground/graphics/okular/; revision=572243
2006-08-11 23:53:48 +00:00