Commit graph

5478 commits

Author SHA1 Message Date
Albert Astals Cid
792eca9fb5 Use [] and & instead of at() + replace() 2011-08-23 15:47:56 +02:00
Albert Astals Cid
8286aac4db We never use m_spaces, so kill it 2011-08-23 15:39:06 +02:00
Albert Astals Cid
917482f0b7 Fix memory leak
Need to delete these two here too
2011-08-23 15:37:43 +02:00
Albert Astals Cid
e842bcdfed No need to if the delete 2011-08-23 15:24:44 +02:00
Mahfuzur Rahman Mamun
d7576a6a2b Fix crashes
1. I replaced the previous fixed memory array with dynamic memory allocation
(line 18-20).
2. Put some extra check so that we do not access under or over the boundary
of arrays (line 29-30,37-38)
3. Removed some unnecessary parts(line 46-48,56-58)
4. Instead of appending already existing element, I have created new
TinyTextEntity elements and removed them after usage(72-73,79)
5. Restored the deletion of words(78). Deletion of word will crash the
program, as all the TinyTextEntity in the nodes of the tree has reference to
words. This memory will be deallocated at line 105.
6. Another change like 4 is done in line 96-97.
2011-08-23 15:22:47 +02:00
Ralf Habacker
2f203f063b avoid non portable resolution setting 2011-08-22 22:56:56 +02:00
Ralf Habacker
6f1a041868 use resolution from printer settings 2011-08-22 22:03:02 +02:00
Ralf Habacker
debd7373d5 Optimized windows printing support by using renderToImage 2011-08-22 22:02:56 +02:00
Ralf Habacker
195c51e8f1 Enable print menu items in windows
BUGS: 190497
2011-08-22 22:02:48 +02:00
Albert Astals Cid
75cac8a3c6 I am pretty sure we need to delete this 2011-08-22 20:40:52 +02:00
Albert Astals Cid
0e1efa6516 rework the API a bit so we can assign it to const variables 2011-08-22 20:36:49 +02:00
Albert Astals Cid
d0d2b45a11 Fix TextPagePrivate::removeSpace iteration
You need to use the iterator returned by erase
2011-08-22 20:29:36 +02:00
Albert Astals Cid
ccc317bc5c remove toAscii().data() since that is already a QString 2011-08-22 20:20:16 +02:00
Albert Astals Cid
2bec8e3aaa add some const, will make the code easier to read later on 2011-08-22 20:19:23 +02:00
Albert Astals Cid
7dbc4f48e1 Do not use this-> 2011-08-22 19:24:42 +02:00
Albert Astals Cid
a4cb8dcce0 Only create the menu if we are going to use it 2011-08-22 19:22:09 +02:00
Albert Astals Cid
d6b5a70951 Mark file local functions static 2011-08-22 19:20:50 +02:00
Albert Astals Cid
0e825cc599 fix potential memory leak 2011-08-22 19:17:47 +02:00
Albert Astals Cid
be8f9bd9cb Rename copy* functions to something I like more 2011-08-22 19:12:21 +02:00
Albert Astals Cid
c78a7069b1 fix bad merge 2011-08-22 19:08:04 +02:00
Albert Astals Cid
a9fd44009e Add some const & 2011-08-22 19:06:29 +02:00
Albert Astals Cid
3f69b491cd Merge branch 'selection_and_highlighting' 2011-08-22 18:50:49 +02:00
Mohammad Mahfuzur Rahman Mamun
c55ee4b70d A last moment refactoring of the code ... some const & changes 2011-08-22 22:36:47 +06:00
Mohammad Mahfuzur Rahman Mamun
dca4ee559c Another Code Refactoring done 2011-08-21 10:44:42 +06:00
Mohammad Mahfuzur Rahman Mamun
88ec0951fe Some code restructure changes in textpage.cpp 2011-08-19 07:01:11 +06:00
Mohammad Mahfuzur Rahman Mamun
73d4a31350 code recommenting done in textpage.cpp 2011-08-18 07:03:46 +06:00
Mohammad Mahfuzur Rahman Mamun
5a8b984f14 debugging and printing removed from textpage.cpp ... need code recomment now 2011-08-17 15:32:40 +06:00
Mohammad Mahfuzur Rahman Mamun
1b8e1fc436 all files other than textpage.cpp has been changed necessarily 2011-08-17 10:59:10 +06:00
Mohammad Mahfuzur Rahman Mamun
3214307ed9 unnecessary changes removed from area.h and cpp textpage.h textpage_p.h 2011-08-17 10:45:46 +06:00
Mohammad Mahfuzur Rahman Mamun
da26410530 unnecessary changes removed from pageview.cpp 2011-08-17 09:26:25 +06:00
Mohammad Mahfuzur Rahman Mamun
8667667222 unnecessary changes removed from pagepainter.cpp 2011-08-17 08:59:08 +06:00
Script Kiddy
cfd881c2ee SVN_SILENT made messages (.desktop file) 2011-08-16 15:21:46 +02:00
Mohammad Mahfuzur Rahman Mamun
3bbc5bc8b8 Removed the case of right click for text Selection where even if no text is selected right click would allow the user to copy text 2011-08-14 08:57:15 +06:00
Mohammad Mahfuzur Rahman Mamun
10b11903c2 Removal of black selection for epub or odt is working with some problem 2011-08-13 16:06:18 +06:00
Albert Astals Cid
84980e7574 For documents with page label, make the lower bar lineedit be the page label instead of number
We show the actual number in a separate qlabel too

Based on a patch by Daniel Oberländer

BUGS: 187237
FIXED-IN: 4.8.0
2011-08-12 14:42:27 +01:00
Mohammad Mahfuzur Rahman Mamun
929e4b6a0e Removed some double selection Problem 2011-08-12 08:25:21 +06:00
Albert Astals Cid
ea82b3eb42 Fix opening hand 2011-08-11 22:46:09 +01:00
Albert Astals Cid
d3ebf089c4 Do not rely on extension but on output format for conversion
BUGS: 277801
2011-08-11 16:17:24 +01:00
Albert Astals Cid
b8870e5bb0 Stat the file before switching to it
This way if the document does not exist at least we do not loose the current file
FIXED-IN: 4.8.0
BUGS: 267344
2011-08-10 10:17:36 +01:00
David Faure
2c9794071a Port away from deprecated API + from deprecated lib 2011-08-10 01:48:01 +02:00
Albert Astals Cid
9f99d536dc Add GUI option to switch off showing the document title
Pleasing users is not so bad
BUGS: 158401
2011-08-09 16:59:49 +01:00
Albert Astals Cid
44c5fbad1e make sure the character position exists before reading it
(cherry picked from commit aa8d593959)
2011-08-08 22:48:39 +01:00
Aleix Pol
390bf78ecc Change mouse cursor when changing the current tool
Update the cursors when changing the current mode. Addresses the problems in the bug report.

- Use a opened/closed hand for browsing.
- Use cross for selection.

BUG: 271816
REVIEW: 102221
2011-08-05 23:47:35 +02:00
Aleix Pol
39fc2a471e Properly check if a file is a readable image by asking QImageReader.
Reviewed by Albert Astals.
2011-08-05 09:47:23 +02:00
Mohammad Mahfuzur Rahman Mamun
b50b622a25 A Little change in the makeandsort lines 2011-08-04 14:35:09 +06:00
Mohammad Mahfuzur Rahman Mamun
1ef68e3301 text selection for both selection type 01 and 02 seems to be working correctly 2011-08-04 10:34:11 +06:00
Mohammad Mahfuzur Rahman Mamun
9a07e04fe3 another try for second type selection 2011-08-03 15:28:33 +06:00
Mohammad Mahfuzur Rahman Mamun
ff289f819c selection 02 implemented but not working perfectly 2011-08-01 19:26:36 +06:00
Montel Laurent
f9f65979f5 Normalize signals/slots 2011-07-31 21:22:04 +02:00
Mohammad Mahfuzur Rahman Mamun
9168932079 trying to solve the second kind of selecction 2011-07-29 18:18:41 +06:00