mirror of
https://invent.kde.org/graphics/okular
synced 2024-11-04 21:09:05 +00:00
Added tests for validating commit and no commit cases for time keystroke action
This commit is contained in:
Pratham Gandhi
parent
68cb2edb8a
commit
ebc02614de
1 changed files with 97 additions and 21 deletions
|
|
@ -26,78 +26,154 @@ private Q_SLOTS:
|
|||
|
||||
void testCommit();
|
||||
void testKeystroke();
|
||||
void testTimeKeystrokeNoCommit();
|
||||
void testTimeKeystrokeNoCommit_data();
|
||||
void testTimeKeystrokeCommit();
|
||||
void testTimeKeystrokeCommit_data();
|
||||
|
||||
private:
|
||||
Okular::Document *m_document;
|
||||
QMap<QString, Okular::FormField *> m_fields;
|
||||
Okular::Document *m_genericTestsDocument;
|
||||
QMap<QString, Okular::FormField *> m_genericTestsFields;
|
||||
Okular::Document *m_AFMethodsTestsDocument;
|
||||
QMap<QString, Okular::FormField *> m_AFMethodsTestsFields;
|
||||
};
|
||||
|
||||
void KeystrokeTest::initTestCase()
|
||||
{
|
||||
Okular::SettingsCore::instance(QStringLiteral("keystroketest"));
|
||||
m_document = new Okular::Document(nullptr);
|
||||
m_genericTestsDocument = new Okular::Document(nullptr);
|
||||
|
||||
// Force consistent locale
|
||||
QLocale locale(QStringLiteral("en_US"));
|
||||
QLocale::setDefault(locale);
|
||||
|
||||
const QString testFile = QStringLiteral(KDESRCDIR "data/keystroketest.pdf");
|
||||
const QString genericTestFile = QStringLiteral(KDESRCDIR "data/keystroketest.pdf");
|
||||
QMimeDatabase db;
|
||||
const QMimeType mime = db.mimeTypeForFile(testFile);
|
||||
QCOMPARE(m_document->openDocument(testFile, QUrl(), mime), Okular::Document::OpenSuccess);
|
||||
const QMimeType genericTestMime = db.mimeTypeForFile(genericTestFile);
|
||||
QCOMPARE(m_genericTestsDocument->openDocument(genericTestFile, QUrl(), genericTestMime), Okular::Document::OpenSuccess);
|
||||
|
||||
const Okular::Page *page = m_document->page(0);
|
||||
const QList<Okular::FormField *> pageFormFields = page->formFields();
|
||||
for (Okular::FormField *ff : pageFormFields) {
|
||||
m_fields.insert(ff->name(), ff);
|
||||
const Okular::Page *genericTestPage = m_genericTestsDocument->page(0);
|
||||
const QList<Okular::FormField *> genericTestPageFormFields = genericTestPage->formFields();
|
||||
for (Okular::FormField *ff : genericTestPageFormFields) {
|
||||
m_genericTestsFields.insert(ff->name(), ff);
|
||||
}
|
||||
|
||||
m_AFMethodsTestsDocument = new Okular::Document(nullptr);
|
||||
const QString AFMethodsTestFile = QStringLiteral(KDESRCDIR "data/formattest.pdf");
|
||||
const QMimeType AFMethodsTestMime = db.mimeTypeForFile(AFMethodsTestFile);
|
||||
QCOMPARE(m_AFMethodsTestsDocument->openDocument(AFMethodsTestFile, QUrl(), AFMethodsTestMime), Okular::Document::OpenSuccess);
|
||||
|
||||
const Okular::Page *AFMethodsTestPage = m_AFMethodsTestsDocument->page(0);
|
||||
const QList<Okular::FormField *> AFMethodsTestPageFormFields = AFMethodsTestPage->formFields();
|
||||
for (Okular::FormField *ff : AFMethodsTestPageFormFields) {
|
||||
m_AFMethodsTestsFields.insert(ff->name(), ff);
|
||||
}
|
||||
}
|
||||
|
||||
void KeystrokeTest::testCommit()
|
||||
{
|
||||
Okular::FormFieldText *fft = reinterpret_cast<Okular::FormFieldText *>(m_fields[QStringLiteral("field2")]);
|
||||
Okular::FormFieldText *fft = reinterpret_cast<Okular::FormFieldText *>(m_genericTestsFields[QStringLiteral("field2")]);
|
||||
|
||||
// text that will be accepted
|
||||
fft->setText(QStringLiteral("Lorem ipsum"));
|
||||
m_document->processKeystrokeCommitAction(fft->additionalAction(Okular::FormField::FieldModified), fft);
|
||||
m_genericTestsDocument->processKeystrokeCommitAction(fft->additionalAction(Okular::FormField::FieldModified), fft);
|
||||
QCOMPARE(fft->text(), QStringLiteral("Lorem ipsum"));
|
||||
|
||||
// text that will be rejected
|
||||
fft->setText(QStringLiteral("foo"));
|
||||
m_document->processKeystrokeCommitAction(fft->additionalAction(Okular::FormField::FieldModified), fft);
|
||||
m_genericTestsDocument->processKeystrokeCommitAction(fft->additionalAction(Okular::FormField::FieldModified), fft);
|
||||
QEXPECT_FAIL("", "reset to commited value not implemented", Continue);
|
||||
QCOMPARE(fft->text(), QStringLiteral("Lorem ipsum"));
|
||||
}
|
||||
|
||||
void KeystrokeTest::testKeystroke()
|
||||
{
|
||||
Okular::FormFieldText *fft = reinterpret_cast<Okular::FormFieldText *>(m_fields[QStringLiteral("field3")]);
|
||||
Okular::FormFieldText *fft = reinterpret_cast<Okular::FormFieldText *>(m_genericTestsFields[QStringLiteral("field3")]);
|
||||
|
||||
// accept
|
||||
m_document->processKeystrokeAction(fft->additionalAction(Okular::FormField::FieldModified), fft, QStringLiteral("hello"), 0, 0);
|
||||
m_genericTestsDocument->processKeystrokeAction(fft->additionalAction(Okular::FormField::FieldModified), fft, QStringLiteral("hello"), 0, 0);
|
||||
QCOMPARE(fft->text(), QStringLiteral("hello"));
|
||||
|
||||
// accept
|
||||
m_document->processKeystrokeAction(fft->additionalAction(Okular::FormField::FieldModified), fft, QStringLiteral("e"), 0, 5);
|
||||
m_genericTestsDocument->processKeystrokeAction(fft->additionalAction(Okular::FormField::FieldModified), fft, QStringLiteral("e"), 0, 5);
|
||||
QCOMPARE(fft->text(), QStringLiteral("e"));
|
||||
|
||||
// accept
|
||||
m_document->processKeystrokeAction(fft->additionalAction(Okular::FormField::FieldModified), fft, QStringLiteral("ee"), 1, 1);
|
||||
m_genericTestsDocument->processKeystrokeAction(fft->additionalAction(Okular::FormField::FieldModified), fft, QStringLiteral("ee"), 1, 1);
|
||||
QCOMPARE(fft->text(), QStringLiteral("ee"));
|
||||
|
||||
// accept
|
||||
m_document->processKeystrokeAction(fft->additionalAction(Okular::FormField::FieldModified), fft, QStringLiteral("eee"), 2, 2);
|
||||
m_genericTestsDocument->processKeystrokeAction(fft->additionalAction(Okular::FormField::FieldModified), fft, QStringLiteral("eee"), 2, 2);
|
||||
QCOMPARE(fft->text(), QStringLiteral("eee"));
|
||||
|
||||
// reject
|
||||
m_document->processKeystrokeAction(fft->additionalAction(Okular::FormField::FieldModified), fft, QStringLiteral("eeef"), 3, 3);
|
||||
m_genericTestsDocument->processKeystrokeAction(fft->additionalAction(Okular::FormField::FieldModified), fft, QStringLiteral("eeef"), 3, 3);
|
||||
QCOMPARE(fft->text(), QStringLiteral("eee"));
|
||||
}
|
||||
|
||||
void KeystrokeTest::testTimeKeystrokeNoCommit()
|
||||
{
|
||||
QFETCH(QString, fieldName);
|
||||
QFETCH(QString, text);
|
||||
QFETCH(int, selStart);
|
||||
QFETCH(int, selEnd);
|
||||
QFETCH(QString, result);
|
||||
|
||||
Okular::FormFieldText *fft = reinterpret_cast<Okular::FormFieldText *>(m_AFMethodsTestsFields[fieldName]);
|
||||
m_AFMethodsTestsDocument->processKeystrokeAction(fft->additionalAction(Okular::FormField::FieldModified), fft, text, selStart, selEnd);
|
||||
|
||||
QCOMPARE(fft->text(), result);
|
||||
}
|
||||
|
||||
void KeystrokeTest::testTimeKeystrokeNoCommit_data()
|
||||
{
|
||||
QTest::addColumn<QString>("fieldName");
|
||||
QTest::addColumn<QString>("text");
|
||||
QTest::addColumn<int>("selStart");
|
||||
QTest::addColumn<int>("selEnd");
|
||||
QTest::addColumn<QString>("result");
|
||||
|
||||
QTest::newRow("AM") << QStringLiteral("time1") << QStringLiteral("am") << 0 << 0 << QStringLiteral("am");
|
||||
QTest::newRow("PM") << QStringLiteral("time1") << QStringLiteral("pm") << 0 << 2 << QStringLiteral("pm");
|
||||
QTest::newRow("hh:mm") << QStringLiteral("time1") << QStringLiteral("20:08") << 0 << 2 << QStringLiteral("20:08");
|
||||
QTest::newRow("hh:mm:ss") << QStringLiteral("time1") << QStringLiteral("20:08:04") << 0 << 5 << QStringLiteral("20:08:04");
|
||||
QTest::newRow("hh:mm pm") << QStringLiteral("time1") << QStringLiteral("20:08 pm") << 5 << 8 << QStringLiteral("20:08 pm");
|
||||
QTest::newRow("other characters") << QStringLiteral("time1") << QStringLiteral("alien") << 0 << 9 << QStringLiteral("20:08 pm");
|
||||
|
||||
// TODO add more tests for rejecting strings
|
||||
}
|
||||
|
||||
void KeystrokeTest::testTimeKeystrokeCommit()
|
||||
{
|
||||
QFETCH(QString, fieldName);
|
||||
QFETCH(QString, text);
|
||||
QFETCH(QString, result);
|
||||
|
||||
Okular::FormFieldText *fft = reinterpret_cast<Okular::FormFieldText *>(m_AFMethodsTestsFields[fieldName]);
|
||||
fft->setText(text);
|
||||
m_AFMethodsTestsDocument->processKeystrokeCommitAction(fft->additionalAction(Okular::FormField::FieldModified), fft);
|
||||
|
||||
QCOMPARE(fft->text(), result);
|
||||
}
|
||||
|
||||
void KeystrokeTest::testTimeKeystrokeCommit_data()
|
||||
{
|
||||
QTest::addColumn<QString>("fieldName");
|
||||
QTest::addColumn<QString>("text");
|
||||
QTest::addColumn<QString>("result");
|
||||
|
||||
QTest::newRow("hh:mm") << QStringLiteral("time1") << QStringLiteral("20:08") << QStringLiteral("20:08");
|
||||
QTest::newRow("hh:mm:ss") << QStringLiteral("time1") << QStringLiteral("20:08:12") << QStringLiteral("20:08:12");
|
||||
QTest::newRow("hh:m:s") << QStringLiteral("time1") << QStringLiteral("20:0:1") << QStringLiteral("20:0:1");
|
||||
QTest::newRow("hh:mm:ss am") << QStringLiteral("time1") << QStringLiteral("20:08:12 am") << QStringLiteral("20:08:12 am");
|
||||
}
|
||||
|
||||
void KeystrokeTest::cleanupTestCase()
|
||||
{
|
||||
m_document->closeDocument();
|
||||
delete m_document;
|
||||
m_genericTestsDocument->closeDocument();
|
||||
delete m_genericTestsDocument;
|
||||
m_AFMethodsTestsDocument->closeDocument();
|
||||
delete m_AFMethodsTestsDocument;
|
||||
}
|
||||
|
||||
QTEST_MAIN(KeystrokeTest)
|
||||
|
|
|
|||
Loading…
Reference in a new issue