Fix low hanging unused parameters warnings

This commit is contained in:
Martin T. H. Sandsmark 2016-07-11 22:57:11 +02:00
parent 25a1915daf
commit d5bdca64d2
9 changed files with 33 additions and 15 deletions

View file

@ -177,6 +177,9 @@ Generator::~Generator()
bool Generator::loadDocument( const QString & fileName, QVector< Page * > & pagesVector ) bool Generator::loadDocument( const QString & fileName, QVector< Page * > & pagesVector )
{ {
Q_UNUSED(fileName);
Q_UNUSED(pagesVector);
return false; return false;
} }
@ -291,6 +294,8 @@ TextPage* Generator::textPage( Page* )
DocumentInfo Generator::generateDocumentInfo(const QSet<DocumentInfo::Key> &keys) const DocumentInfo Generator::generateDocumentInfo(const QSet<DocumentInfo::Key> &keys) const
{ {
Q_UNUSED(keys);
return DocumentInfo(); return DocumentInfo();
} }

View file

@ -99,6 +99,9 @@ Rotation RotationJobInternal::rotation() const
void RotationJobInternal::run(ThreadWeaver::JobPointer self, ThreadWeaver::Thread *thread) void RotationJobInternal::run(ThreadWeaver::JobPointer self, ThreadWeaver::Thread *thread)
{ {
Q_UNUSED(self);
Q_UNUSED(thread);
if ( mOldRotation == mNewRotation ) { if ( mOldRotation == mNewRotation ) {
mRotatedImage = mImage; mRotatedImage = mImage;
return; return;

View file

@ -1837,9 +1837,8 @@ synctex_status_t _synctex_setup_visible_box(synctex_node_t box) {
* With this method, one can enlarge the box to contain the given point (h,v). * With this method, one can enlarge the box to contain the given point (h,v).
*/ */
synctex_status_t _synctex_horiz_box_setup_visible(synctex_node_t node,int h, int v) { synctex_status_t _synctex_horiz_box_setup_visible(synctex_node_t node,int h, int v) {
# ifdef __DARWIN_UNIX03 (void)v; /* unused */
# pragma unused(v)
# endif
int itsBtm, itsTop; int itsBtm, itsTop;
if (NULL == node || node->class->type != synctex_node_type_hbox) { if (NULL == node || node->class->type != synctex_node_type_hbox) {
return SYNCTEX_STATUS_BAD_ARGUMENT; return SYNCTEX_STATUS_BAD_ARGUMENT;
@ -3261,9 +3260,7 @@ int synctex_node_line(synctex_node_t node) {
return node?SYNCTEX_LINE(node):-1; return node?SYNCTEX_LINE(node):-1;
} }
int synctex_node_column(synctex_node_t node) { int synctex_node_column(synctex_node_t node) {
# ifdef __DARWIN_UNIX03 (void)node; /* unused */
# pragma unused(node)
# endif
return -1; return -1;
} }
# ifdef SYNCTEX_NOTHING # ifdef SYNCTEX_NOTHING
@ -3290,9 +3287,8 @@ synctex_node_t synctex_sheet_content(synctex_scanner_t scanner,int page) {
# endif # endif
int synctex_display_query(synctex_scanner_t scanner,const char * name,int line,int column) { int synctex_display_query(synctex_scanner_t scanner,const char * name,int line,int column) {
# ifdef __DARWIN_UNIX03 (void)column; /* unused */
# pragma unused(column)
# endif
int tag = synctex_scanner_get_tag(scanner,name); int tag = synctex_scanner_get_tag(scanner,name);
size_t size = 0; size_t size = 0;
int friend_index = 0; int friend_index = 0;
@ -3689,9 +3685,8 @@ int _synctex_point_h_distance(synctex_point_t hitPoint, synctex_node_t node, syn
* if node is at the bottom of the hit point, this distance is negative.*/ * if node is at the bottom of the hit point, this distance is negative.*/
int _synctex_point_v_distance(synctex_point_t hitPoint, synctex_node_t node,synctex_bool_t visible); int _synctex_point_v_distance(synctex_point_t hitPoint, synctex_node_t node,synctex_bool_t visible);
int _synctex_point_v_distance(synctex_point_t hitPoint, synctex_node_t node,synctex_bool_t visible) { int _synctex_point_v_distance(synctex_point_t hitPoint, synctex_node_t node,synctex_bool_t visible) {
# ifdef __DARWIN_UNIX03 (void)visible; /* unused */
# pragma unused(visible)
# endif
if (node) { if (node) {
int min,max; int min,max;
switch(node->class->type) { switch(node->class->type) {
@ -3779,9 +3774,8 @@ synctex_bool_t _synctex_point_in_box(synctex_point_t hitPoint, synctex_node_t no
} }
int _synctex_node_distance_to_point(synctex_point_t hitPoint, synctex_node_t node, synctex_bool_t visible) { int _synctex_node_distance_to_point(synctex_point_t hitPoint, synctex_node_t node, synctex_bool_t visible) {
# ifdef __DARWIN_UNIX03 (void)visible;
# pragma unused(visible)
# endif
int result = INT_MAX; /* when the distance is meaning less (sheet, input...) */ int result = INT_MAX; /* when the distance is meaning less (sheet, input...) */
if (node) { if (node) {
int minH,maxH,minV,maxV; int minH,maxH,minV,maxV;

View file

@ -153,6 +153,8 @@ bool KIMGIOGenerator::print( QPrinter& printer )
Okular::DocumentInfo KIMGIOGenerator::generateDocumentInfo( const QSet<Okular::DocumentInfo::Key> &keys ) const Okular::DocumentInfo KIMGIOGenerator::generateDocumentInfo( const QSet<Okular::DocumentInfo::Key> &keys ) const
{ {
Q_UNUSED(keys);
return docInfo; return docInfo;
} }

View file

@ -2127,6 +2127,8 @@ Okular::TextPage* XpsGenerator::textPage( Okular::Page * page )
Okular::DocumentInfo XpsGenerator::generateDocumentInfo( const QSet<Okular::DocumentInfo::Key> &keys ) const Okular::DocumentInfo XpsGenerator::generateDocumentInfo( const QSet<Okular::DocumentInfo::Key> &keys ) const
{ {
Q_UNUSED(keys);
qCWarning(OkularXpsDebug) << "generating document metadata"; qCWarning(OkularXpsDebug) << "generating document metadata";
return m_xpsFile->generateDocumentInfo(); return m_xpsFile->generateDocumentInfo();

View file

@ -921,6 +921,8 @@ QUrl Part::realUrl() const
void Part::showSourceLocation(const QString& fileName, int line, int column, bool showGraphically) void Part::showSourceLocation(const QString& fileName, int line, int column, bool showGraphically)
{ {
Q_UNUSED(column);
const QString u = QStringLiteral( "src:%1 %2" ).arg( line + 1 ).arg( fileName ); const QString u = QStringLiteral( "src:%1 %2" ).arg( line + 1 ).arg( fileName );
GotoAction action( QString(), u ); GotoAction action( QString(), u );
m_document->processAction( &action ); m_document->processAction( &action );

View file

@ -143,6 +143,8 @@ Shell::Shell( const QString &serializedOptions )
bool Shell::eventFilter(QObject *obj, QEvent *event) bool Shell::eventFilter(QObject *obj, QEvent *event)
{ {
Q_UNUSED(obj);
QDragMoveEvent* dmEvent = dynamic_cast<QDragMoveEvent*>(event); QDragMoveEvent* dmEvent = dynamic_cast<QDragMoveEvent*>(event);
if (dmEvent) { if (dmEvent) {
bool accept = dmEvent->mimeData()->hasUrls(); bool accept = dmEvent->mimeData()->hasUrls();

View file

@ -811,6 +811,8 @@ void ListEdit::slotHandleFormListChangedByUndoRedo( int pageNumber,
Okular::FormFieldChoice* listForm, Okular::FormFieldChoice* listForm,
const QList< int > & choices ) const QList< int > & choices )
{ {
Q_UNUSED(pageNumber);
if ( m_form != listForm ) { if ( m_form != listForm ) {
return; return;
} }
@ -904,6 +906,8 @@ void ComboEdit::slotHandleFormComboChangedByUndoRedo( int pageNumber,
int cursorPos, int cursorPos,
int anchorPos ) int anchorPos )
{ {
Q_UNUSED(pageNumber);
if ( m_form != form ) { if ( m_form != form ) {
return; return;
} }

View file

@ -165,6 +165,8 @@ void SearchLineEdit::findPrev()
void SearchLineEdit::slotTextChanged( const QString & text ) void SearchLineEdit::slotTextChanged( const QString & text )
{ {
Q_UNUSED(text);
prepareLineEditForSearch(); prepareLineEditForSearch();
restartSearch(); restartSearch();
} }
@ -190,6 +192,8 @@ void SearchLineEdit::prepareLineEditForSearch()
void SearchLineEdit::slotReturnPressed( const QString &text ) void SearchLineEdit::slotReturnPressed( const QString &text )
{ {
Q_UNUSED(text);
m_inputDelayTimer->stop(); m_inputDelayTimer->stop();
prepareLineEditForSearch(); prepareLineEditForSearch();
if ( QApplication::keyboardModifiers() == Qt::ShiftModifier ) if ( QApplication::keyboardModifiers() == Qt::ShiftModifier )