office/okular
office/okular
1
0
Fork 0
mirror of https://invent.kde.org/graphics/okular synced 2024-10-02 22:23:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Only show certificates that are still valid when signing

Browse source 
No point in letting people sign a file with a certificate that's no
longer valid
This commit is contained in:
Albert Astals Cid 2020-12-14 15:15:13 +01:00 committed by Albert Astals Cid
parent 6cf0ca2194
commit bb97810957
1 changed files with 15 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
part/pageviewannotator.cpp
View file

@ -364,20 +364,27 @@ public:
QStringList items;
QHash<QString, Okular::CertificateInfo *> nickToCert;
const QDateTime now = QDateTime::currentDateTime();
for (auto cert : certs) {
items.append(cert->nickName());
nickToCert[cert->nickName()] = cert;
if (cert->validityStart() <= now && now <= cert->validityEnd()) {
items.append(cert->nickName());
nickToCert[cert->nickName()] = cert;
}
}
if (items.isEmpty()) {
m_creationCompleted = false;
clicked = false;
KMessageBox::information(m_pageView,
i18n("There are no available signing certificates.<br/>For more information, please see the section about <a href=\"%1\">Adding Digital Signatures</a> in the manual.",
QStringLiteral("help:/okular/index.html#adding_digital_signatures")),
QString(),
QString(),
KMessageBox::Notify | KMessageBox::AllowLink);
if (certs.isEmpty()) {
KMessageBox::information(m_pageView,
i18n("There are no available signing certificates.<br/>For more information, please see the section about <a href=\"%1\">Adding Digital Signatures</a> in the manual.",
QStringLiteral("help:/okular/index.html#adding_digital_signatures")),
QString(),
QString(),
KMessageBox::Notify | KMessageBox::AllowLink);
} else {
KMessageBox::information(m_pageView, i18n("All your signing certificates are either not valid yet or are past their validity date."));
}
return {};
}