office/okular
office/okular
1
0
Fork 0
mirror of https://invent.kde.org/graphics/okular synced 2024-11-05 18:34:53 +00:00
Code Issues Projects Releases Packages Wiki Activity

Port sidebar delegate to KColorScheme.

Browse source 
Certain KDE color schemes have Window Background and View Text
not contrasting, which causes invisible icon labels when using
QPalette::Text on QPalette::Base. An example is the default
color scheme in openSUSE 12.3.

Thanks to Will Stephenson for noticing.
CCMAIL:wstephenson@kde.org

It turns out that the Places sidebar in Dolphin suffers from
the same bug, so a similar change should be done there. Frank?
CCMAIL:frank78ac@googlemail.com
This commit is contained in:
Eike Hein 2013-02-13 12:59:55 +01:00
parent a034e086e5
commit a3b3545cab
1 changed files with 14 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
ui/sidebar.cpp
View file

@ -29,6 +29,7 @@
#include <kiconloader.h>
#include <klocale.h>
#include <kmenu.h>
#include <kcolorscheme.h>
#include "settings.h"
@ -107,27 +108,32 @@ void SidebarDelegate::paint( QPainter *painter, const QStyleOptionViewItem &opti
QColor foreColor;
bool disabled = false;
bool hover = false;
if ( !( option.state & QStyle::State_Enabled ) )
{
backBrush = option.palette.brush( QPalette::Disabled, QPalette::Base );
foreColor = option.palette.color( QPalette::Disabled, QPalette::Text );
KColorScheme colorScheme( QPalette::Disabled, KColorScheme::Window );
backBrush = colorScheme.background();
foreColor = colorScheme.foreground().color();
disabled = true;
}
else if ( option.state & ( QStyle::State_HasFocus | QStyle::State_Selected ) )
{
backBrush = option.palette.brush( QPalette::Highlight );
foreColor = option.palette.color( QPalette::HighlightedText );
KColorScheme colorScheme( option.palette.currentColorGroup(), KColorScheme::Selection );
backBrush = colorScheme.background();
foreColor = colorScheme.foreground().color();
}
else if ( option.state & QStyle::State_MouseOver )
{
backBrush = option.palette.color( QPalette::Highlight ).light( 115 );
foreColor = option.palette.color( QPalette::HighlightedText );
KColorScheme colorScheme( option.palette.currentColorGroup(), KColorScheme::Selection );
backBrush = colorScheme.background().color().light( 115 );
foreColor = colorScheme.foreground().color();
hover = true;
}
else /*if ( option.state & QStyle::State_Enabled )*/
{
backBrush = option.palette.brush( QPalette::Base );
foreColor = option.palette.color( QPalette::Text );
KColorScheme colorScheme( option.palette.currentColorGroup(), KColorScheme::Window );
backBrush = colorScheme.background();
foreColor = colorScheme.foreground().color();
}
QStyle *style = QApplication::style();
QStyleOptionViewItemV4 opt( option );