office/okular
office/okular
1
0
Fork 0
mirror of https://invent.kde.org/graphics/okular synced 2024-08-27 03:30:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make sure sorting in the configure backends is always the same

Browse source 
The sorting is not the best, but at least it's always the same now :D
This commit is contained in:
Albert Astals Cid 2018-08-14 10:37:30 +02:00
parent 5e622484c8
commit 9ba8dd2cd7
1 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
core/document.cpp
View file

@ -4463,12 +4463,23 @@ void Document::fillConfigDialog( KConfigDialog * dialog )
QVector<KPluginMetaData> offers = DocumentPrivate::configurableGenerators();
d->loadServiceList( offers );
bool pagesAdded = false;
// We want the generators to be sorted by name so let's fill in a QMap
// this sorts by internal id which is not awesome, but at least the sorting
// is stable between runs that before it wasn't
QMap<QString, GeneratorInfo> sortedGenerators;
QHash< QString, GeneratorInfo >::iterator it = d->m_loadedGenerators.begin();
QHash< QString, GeneratorInfo >::iterator itEnd = d->m_loadedGenerators.end();
for ( ; it != itEnd; ++it )
{
Okular::ConfigInterface * iface = d->generatorConfig( it.value() );
sortedGenerators.insert(it.key(), it.value());
}
bool pagesAdded = false;
QMap< QString, GeneratorInfo >::iterator sit = sortedGenerators.begin();
QMap< QString, GeneratorInfo >::iterator sitEnd = sortedGenerators.end();
for ( ; sit != sitEnd; ++sit )
{
Okular::ConfigInterface * iface = d->generatorConfig( sit.value() );
if ( iface )
{
iface->addPages( dialog );