office/okular
office/okular
1
0
Fork 0
mirror of https://invent.kde.org/graphics/okular synced 2024-10-01 05:33:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use QStringView more to reduce allocations

Browse source
This commit is contained in:
Fushan Wen 2024-02-20 12:11:37 +08:00 committed by Albert Astals Cid
parent 5ae81f4486
commit 677a2467ba
3 changed files with 10 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
generators/comicbook/unrar.cpp
View file

@ -46,7 +46,8 @@ static UnrarFlavour *detectUnrar(const QString &unrarPath, const QString &versio
bool ok = proc.waitForFinished(-1);
Q_UNUSED(ok)
static const QRegularExpression regex(QStringLiteral("[\r\n]"));
const QStringList lines = QString::fromLocal8Bit(proc.readAllStandardOutput()).split(regex, Qt::SkipEmptyParts);
const QString output = QString::fromLocal8Bit(proc.readAllStandardOutput());
const QList<QStringView> lines = QStringView(output).split(regex, Qt::SkipEmptyParts);
if (!lines.isEmpty()) {
if (lines.first().startsWith(QLatin1String("UNRAR "))) {
kind = new NonFreeUnrarFlavour();

8
generators/xps/generator_xps.cpp
View file

@ -73,9 +73,9 @@ static QColor hexToRgba(const QByteArray &name)
return QColor(r, g, b, a);
}
static QRectF stringToRectF(const QString &data)
static QRectF stringToRectF(QStringView data)
{
QStringList numbers = data.split(QLatin1Char(','));
const QList<QStringView> numbers = data.split(QLatin1Char(','));
QPointF origin(numbers.at(0).toDouble(), numbers.at(1).toDouble());
QSizeF size(numbers.at(2).toDouble(), numbers.at(3).toDouble());
return QRectF(origin, size);
@ -864,8 +864,8 @@ void XpsPage::processImageBrush(XpsRenderNode &node)
QString att;
QBrush brush;
QRectF viewport = stringToRectF(node.attributes.value(QStringLiteral("Viewport")).toString());
QRectF viewbox = stringToRectF(node.attributes.value(QStringLiteral("Viewbox")).toString());
QRectF viewport = stringToRectF(node.attributes.value(QStringLiteral("Viewport")));
QRectF viewbox = stringToRectF(node.attributes.value(QStringLiteral("Viewbox")));
QImage image = loadImageFromFile(node.attributes.value(QStringLiteral("ImageSource")).toString());
// Matrix which can transform [0, 0, 1, 1] rectangle to given viewbox

8
part/part.cpp
View file

@ -1756,10 +1756,10 @@ bool Part::openUrl(const QUrl &_url, bool swapInsteadOfOpening)
int page = dest.toInt(&ok);
if (!ok) {
const QStringList parameters = dest.split(QLatin1Char('&'));
for (const QString &parameter : parameters) {
if (parameter.startsWith(QStringLiteral("page="), Qt::CaseInsensitive)) {
page = QStringView {dest}.mid(5).toInt(&ok);
const QList<QStringView> parameters = QStringView(dest).split(QLatin1Char('&'));
for (const QStringView parameter : parameters) {
if (parameter.startsWith(QLatin1String("page="), Qt::CaseInsensitive)) {
page = QStringView(dest).mid(5).toInt(&ok);
}
}
}