mirror of
https://invent.kde.org/graphics/okular
synced 2024-10-01 05:33:33 +00:00
remove BookmarkManager::setPageBookmark
It is only used by addBookmark(int page), which can be implemented in terms of addBookmark(DocumentViewport)
This commit is contained in:
parent
1b78471a41
commit
5b90fcb34d
|
@ -398,10 +398,13 @@ QHash<QUrl, QString>::iterator BookmarkManager::Private::bookmarkFind(const QUrl
|
|||
|
||||
void BookmarkManager::addBookmark(int page)
|
||||
{
|
||||
if (page >= 0 && page < (int)d->document->m_pagesVector.count()) {
|
||||
if (setPageBookmark(page))
|
||||
foreachObserver(notifyPageChanged(page, DocumentObserver::Bookmark));
|
||||
if (isBookmarked(page)) {
|
||||
return;
|
||||
}
|
||||
|
||||
DocumentViewport vp;
|
||||
vp.pageNumber = page;
|
||||
addBookmark(vp);
|
||||
}
|
||||
|
||||
void BookmarkManager::addBookmark(const DocumentViewport &vp)
|
||||
|
@ -651,37 +654,6 @@ void BookmarkManager::setUrl(const QUrl &url)
|
|||
}
|
||||
}
|
||||
|
||||
bool BookmarkManager::setPageBookmark(int page)
|
||||
{
|
||||
KBookmarkGroup thebg;
|
||||
QHash<QUrl, QString>::iterator it = d->bookmarkFind(d->url, true, &thebg);
|
||||
Q_ASSERT(it != d->knownFiles.end());
|
||||
|
||||
bool found = false;
|
||||
bool added = false;
|
||||
for (KBookmark bm = thebg.first(); !found && !bm.isNull(); bm = thebg.next(bm)) {
|
||||
if (bm.isSeparator() || bm.isGroup()) {
|
||||
continue;
|
||||
}
|
||||
|
||||
DocumentViewport vp(bm.url().fragment(QUrl::FullyDecoded));
|
||||
if (vp.isValid() && vp.pageNumber == page) {
|
||||
found = true;
|
||||
}
|
||||
}
|
||||
if (!found) {
|
||||
d->urlBookmarks[page]++;
|
||||
DocumentViewport vp;
|
||||
vp.pageNumber = page;
|
||||
QUrl newurl = d->url;
|
||||
newurl.setFragment(vp.toString(), QUrl::DecodedMode);
|
||||
thebg.addBookmark(QLatin1String("#") + QString::number(vp.pageNumber + 1), newurl, QString());
|
||||
added = true;
|
||||
d->manager.emitChanged(thebg);
|
||||
}
|
||||
return added;
|
||||
}
|
||||
|
||||
bool BookmarkManager::removePageBookmark(int page)
|
||||
{
|
||||
KBookmarkGroup thebg;
|
||||
|
|
|
@ -197,7 +197,6 @@ private:
|
|||
explicit BookmarkManager(DocumentPrivate *document);
|
||||
|
||||
void setUrl(const QUrl &url);
|
||||
bool setPageBookmark(int page);
|
||||
bool removePageBookmark(int page);
|
||||
|
||||
Q_DISABLE_COPY(BookmarkManager)
|
||||
|
|
Loading…
Reference in a new issue