office/okular
office/okular
1
0
Fork 0
mirror of https://invent.kde.org/graphics/okular synced 2024-06-30 22:54:24 +00:00
Code Issues Projects Releases Wiki Activity

remove BookmarkManager::setPageBookmark

Browse Source 
It is only used by addBookmark(int page), which can be implemented in terms of addBookmark(DocumentViewport)
This commit is contained in:
Joe Dight 2024-05-22 11:20:54 +01:00 committed by Albert Astals Cid
parent 1b78471a41
commit 5b90fcb34d
2 changed files with 6 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
core/bookmarkmanager.cpp
View File

@ -398,10 +398,13 @@ QHash<QUrl, QString>::iterator BookmarkManager::Private::bookmarkFind(const QUrl
void BookmarkManager::addBookmark(int page)
{
if (page >= 0 && page < (int)d->document->m_pagesVector.count()) {
if (setPageBookmark(page))
foreachObserver(notifyPageChanged(page, DocumentObserver::Bookmark));
if (isBookmarked(page)) {
return;
}
DocumentViewport vp;
vp.pageNumber = page;
addBookmark(vp);
}
void BookmarkManager::addBookmark(const DocumentViewport &vp)
@ -651,37 +654,6 @@ void BookmarkManager::setUrl(const QUrl &url)
}
}
bool BookmarkManager::setPageBookmark(int page)
{
KBookmarkGroup thebg;
QHash<QUrl, QString>::iterator it = d->bookmarkFind(d->url, true, &thebg);
Q_ASSERT(it != d->knownFiles.end());
bool found = false;
bool added = false;
for (KBookmark bm = thebg.first(); !found && !bm.isNull(); bm = thebg.next(bm)) {
if (bm.isSeparator() || bm.isGroup()) {
continue;
}
DocumentViewport vp(bm.url().fragment(QUrl::FullyDecoded));
if (vp.isValid() && vp.pageNumber == page) {
found = true;
}
}
if (!found) {
d->urlBookmarks[page]++;
DocumentViewport vp;
vp.pageNumber = page;
QUrl newurl = d->url;
newurl.setFragment(vp.toString(), QUrl::DecodedMode);
thebg.addBookmark(QLatin1String("#") + QString::number(vp.pageNumber + 1), newurl, QString());
added = true;
d->manager.emitChanged(thebg);
}
return added;
}
bool BookmarkManager::removePageBookmark(int page)
{
KBookmarkGroup thebg;

1
core/bookmarkmanager.h
View File

@ -197,7 +197,6 @@ private:
explicit BookmarkManager(DocumentPrivate *document);
void setUrl(const QUrl &url);
bool setPageBookmark(int page);
bool removePageBookmark(int page);
Q_DISABLE_COPY(BookmarkManager)