office/okular
office/okular
1
0
Fork 0
mirror of https://invent.kde.org/graphics/okular synced 2024-07-04 16:48:48 +00:00
Code Issues Projects Releases Wiki Activity

The doesConsumeX method was defined but never used

Browse Source 
Having functions which are defined but not used serves no gain. This patch
therefore removes the extra method and updates the comment reference in the
second one to make it standalone.

REVIEW: 114959
This commit is contained in:
Jan Kundrát 2014-01-10 18:28:07 +01:00
parent 677e0660fa
commit 2bd0ec5fda
1 changed files with 1 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
core/textpage.cpp
View File

@ -63,38 +63,11 @@ static bool CaseSensitiveCmpFn( const QStringRef & from, const QStringRef & to )
}
/**
* If the horizontal arm of one rectangle fully contains the other (example below)
* If the vertical arm of one rectangle fully contains the other (example below)
* -------- ---- ----- first
* ---- -------- ----- second
* or we can make it overlap of spaces by threshold%
*/
static bool doesConsumeX(const QRect& first, const QRect& second, int threshold)
{
// if one consumes another fully
if(first.left() <= second.left() && first.right() >= second.right())
return true;
if(first.left() >= second.left() && first.right() <= second.right())
return true;
// or if there is overlap of space by more than threshold%
// there is overlap
if(second.right() >= first.left() && first.right() >= second.left())
{
const int overlap = (second.right() >= first.right()) ? first.right() - second.left()
: second.right() - first.left();
// we will divide by the smaller rectangle to calculate the overlap
const int percentage = (first.width() < second.width()) ? overlap * 100 / (first.right() - first.left())
: overlap * 100 / (second.right() - second.left());
if(percentage >= threshold) return true;
}
return false;
}
/**
* Same concept of doesConsumeX but in this case we calculate on y axis
*/
static bool doesConsumeY(const QRect& first, const QRect& second, int threshold)
{
// if one consumes another fully