office/okular
office/okular
1
0
Fork 0
mirror of https://invent.kde.org/graphics/okular synced 2024-10-01 05:33:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

AnnotationModel: don't emit layoutChanged from inside reset

Browse source 
rebuildTree's only caller is notifySetup() which does a reset,
don't emit layoutChanged() between beginResetModel and endResetModel.

Caught by QAbstractItemModelTester (after instanciating one
in the AnnotationModel constructor to debug something else)
This commit is contained in:
David Faure 2024-05-05 13:32:25 +02:00
parent 8733e544e3
commit 2592879c4a
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
part/annotationmodel.cpp
View file

@ -256,7 +256,6 @@ void AnnotationModelPrivate::rebuildTree(const QVector<Okular::Page *> &pages)
return;
}
Q_EMIT q->layoutAboutToBeChanged();
for (int i = 0; i < pages.count(); ++i) {
const QList<Okular::Annotation *> annots = filterOutWidgetAnnotations(pages.at(i)->annotations());
if (annots.isEmpty()) {
@ -268,7 +267,6 @@ void AnnotationModelPrivate::rebuildTree(const QVector<Okular::Page *> &pages)
new AnnItem(annItem, annot);
}
}
Q_EMIT q->layoutChanged();
}
AnnItem *AnnotationModelPrivate::findItem(int page, int *index) const