Random minor/pedantic fixes

This commit is contained in:
Sune Vuorela 2023-06-16 16:26:27 +02:00 committed by Albert Astals Cid
parent 9649f3c265
commit 0c383d8cfc
8 changed files with 14 additions and 3 deletions

View File

@ -1930,6 +1930,9 @@ class HighlightAnnotation::Quad::Private
{
public:
Private()
: m_capStart(false)
, m_capEnd(false)
, m_feather(0.0)
{
}

View File

@ -5932,7 +5932,7 @@ struct Okular::NewSignatureDataPrivate {
QString location;
QString reason;
QString backgroundImagePath;
int page;
int page = -1;
NormalizedRect boundingRectangle;
};

View File

@ -126,6 +126,7 @@ public:
, m_fontsCached(false)
, m_annotationEditingEnabled(true)
, m_annotationBeingModified(false)
, m_undoStack(nullptr)
, m_docdataMigrationNeeded(false)
, m_synctex_scanner(nullptr)
{

View File

@ -17,6 +17,7 @@ using namespace Okular;
FormFieldPrivate::FormFieldPrivate(FormField::FieldType type)
: m_type(type)
, m_activateAction(nullptr)
, q_ptr(nullptr)
{
}

View File

@ -10,6 +10,7 @@
using namespace Okular;
DocumentObserver::DocumentObserver()
: d(nullptr)
{
}

View File

@ -54,6 +54,7 @@ public:
QList<TOCItem *> currentPage;
TOCModel *m_oldModel;
QVector<QModelIndex> m_oldTocExpandedIndexes;
Q_DISABLE_COPY(TOCModelPrivate);
};
TOCItem::TOCItem()
@ -97,6 +98,7 @@ TOCModelPrivate::TOCModelPrivate(TOCModel *qq)
: q(qq)
, root(new TOCItem)
, dirty(false)
, document(nullptr)
, m_oldModel(nullptr)
{
root->model = this;

View File

@ -40,7 +40,7 @@ public:
enum Button { None, Left, Right };
/** To tell the annotator engine about modifier keys and other special wishes */
struct Modifiers {
bool constrainRatioAndAngle; ///< Whether the engine shall snap to certain angles, if supported.
bool constrainRatioAndAngle = false; ///< Whether the engine shall snap to certain angles, if supported.
};
// perform operations

View File

@ -106,12 +106,15 @@ void MagnifierView::move(int x, int y)
void MagnifierView::requestPixmap()
{
if (!m_page) {
return;
}
const int full_width = m_page->width() * SCALE;
const int full_height = m_page->height() * SCALE;
Okular::NormalizedRect nrect = normalizedView();
if (m_page && !m_page->hasPixmap(this, full_width, full_height, nrect)) {
if (!m_page->hasPixmap(this, full_width, full_height, nrect)) {
Okular::PixmapRequest *p = new Okular::PixmapRequest(this, m_current, full_width, full_height, devicePixelRatioF(), PAGEVIEW_PRIO, Okular::PixmapRequest::Asynchronous);
if (m_page->hasTilesManager(this)) {