office/okular
office/okular
1
0
Fork 0
mirror of https://invent.kde.org/graphics/okular synced 2024-10-30 01:38:07 +00:00
Code Issues Projects Releases Packages Wiki Activity

Use KIO::OpenUrlJob instead of KRun::runService

Browse source 
Works much better in Windows
This commit is contained in:
Albert Astals Cid 2023-03-21 22:07:53 +01:00
parent 9b97052053
commit 052264c3e5
1 changed files with 14 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
core/document.cpp
View file

@ -54,6 +54,8 @@
#include <KConfigDialog>
#include <KFormat>
#include <KIO/Global>
#include <KIO/JobUiDelegateFactory>
#include <KIO/OpenUrlJob>
#include <KLocalizedString>
#include <KMacroExpander>
#include <KPluginMetaData>
@ -61,6 +63,7 @@
#include <KRun>
#include <KShell>
#include <Kdelibs4Migration>
#include <kio_version.h>
#include <kzip.h>
// local includes
@ -4174,6 +4177,16 @@ void Document::processAction(const Action *action)
}
}
#if KIO_VERSION >= QT_VERSION_CHECK(5, 98, 0)
KIO::OpenUrlJob *job = new KIO::OpenUrlJob(url, mime.name());
job->setUiDelegate(KIO::createDefaultJobUiDelegate(KJobUiDelegate::AutoHandlingEnabled, d->m_widget));
job->start();
connect(job, &KIO::OpenUrlJob::result, this, [this, mime](KJob *job) {
if (job->error()) {
Q_EMIT error(i18n("No application found for opening file of mimetype %1.", mime.name()), -1);
}
});
#else
KService::Ptr ptr = KApplicationTrader::preferredService(mime.name());
if (ptr) {
QList<QUrl> lst;
@ -4182,6 +4195,7 @@ void Document::processAction(const Action *action)
} else {
Q_EMIT error(i18n("No application found for opening file of mimetype %1.", mime.name()), -1);
}
#endif
} break;
case Action::DocAction: {