office/okular
office/okular
1
0
Fork 0
mirror of https://invent.kde.org/graphics/okular synced 2024-08-27 11:40:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix isNull check for RegularArea

Browse source 
Summary:
First check in RegularArea::isNull sais this: "I'm a QList. If I'm empty, I'm not null". That doesn't make sense, invert it.

The next check says: "If I contain at least one shape which is not null, I'm not null.". That makes sense, keep it.

Test Plan: - check for regression in callers (TextPage::findText, TextPage::text, TextPage::words)

Reviewers: aacid

Reviewed By: aacid

Subscribers: okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D15344
This commit is contained in:
Tobias Deiminger 2018-09-08 10:47:31 +02:00
parent d61cef693d
commit 0128f33f43
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
core/area.h
View file

@ -669,7 +669,7 @@ template <class NormalizedShape, class Shape>
bool RegularArea<NormalizedShape, Shape>::isNull() const
{
if ( this->isEmpty() )
return false;
return true;
typename QList<NormalizedShape>::const_iterator it = this->begin(), itEnd = this->end();
for ( ; it != itEnd; ++it )