ev_presentation_delete_job already checks whether the job is NULL,
and finishes with a g_object_unref which warranties that
pview->*_job = NULL
So there's no need to set them afterwards.
Those functions already check internally before doing any tasks, and
make sure to nullify whatever they clear, so setting those to NULL
is not necessary either.
This was introduced in 17859243df with
the rationale:
Even if we now render a background in _draw() with
gtk_render_background, using gtk_style_context_set_background() in
realize makes the backing GdkWindow not being completely transparent,
which enables GTK to apply optimizations during the paint cycle.
The result is, especially in clutter-gtk applications such as Documents,
scrolling in a document page is much smoother.
https://bugzilla.gnome.org/show_bug.cgi?id=692988
Clutter was completely archived in GNOME 42 https://blogs.gnome.org/clutter/
so the rationale does no longer hold. Since the call is deprecated, just
remove it, as it is unncessary.
Remove 'Save curent settings as default` because it was confusing,
and a non-standard action in the desktop.
Save exactly the same settings once we know the document will be
closed, and when there is an actual document opened (e.g. not in
recent view).
Fixes#1138
When SCROLLING_TO_PAGE in a continuous view with
a FIT_PAGE sizing mode, let's center the page a
bit better so the next page is not visible.
Fixes#1868Fixes#1905
This simplifies the GTK4 move. Now, instead of recreating the
models when the document changes from having to not having annotations,
simply store those models and change between them.
Coauthored-by: default avatarQiu Wenbo <qiuwenbo@kylinos.com.cn>
Before Evince used GtkHeaderBar, there was a toolbar that was possible
to hide. That toolbar does not exist since it got intergrated into
the header bar.
* Add libhandy-1 as of now it should be available in at least one
major version of the main distributions, and we are ready to
remove libhandy-1 as subproject
* Update to a recent version of poppler
Two changes:
1) Same as with 'Print section' item, only enable it when
clicking over the selected path. This avoids confusion as
the user may previously doubt if the action was for the
selected path or the path under the mouse pointer.
2) Revert 'enabling only when the selected path has
grandchildren'. Avoids confusion as the user may doubt
why the action is disabled when there's an arrow to
expand the path. Now we only check if it has any child
to enable the action.
