office/evince
office/evince
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/evince synced 2024-06-30 22:54:23 +00:00
Code Issues Projects Releases Wiki Activity

shell: Fix use-after-free on a modified document

Browse Source 
Fix use-after-free on a modified document by disconnecting document
modified signal on window close.

Fixes #1766
This commit is contained in:
Gary Li 2022-10-26 15:23:35 +00:00 committed by Germán Poo-Caamaño
parent 0a4a7a1944
commit 8ef197b1da
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
shell/ev-window.c
View File

@ -209,6 +209,7 @@ typedef struct {
/* Has the document been modified? */
gboolean is_modified;
guint modified_handler_id;
/* Load params */
EvLinkDest *dest;
@ -1789,7 +1790,7 @@ ev_window_set_document (EvWindow *ev_window, EvDocument *document)
}
priv->is_modified = FALSE;
g_signal_connect (document, "notify::modified", G_CALLBACK (ev_window_document_modified_cb), ev_window);
priv->modified_handler_id = g_signal_connect (document, "notify::modified", G_CALLBACK (ev_window_document_modified_cb), ev_window);
if (priv->setup_document_idle > 0)
g_source_remove (priv->setup_document_idle);
@ -4124,6 +4125,11 @@ ev_window_close (EvWindow *ev_window)
ev_document_model_set_page (priv->model, current_page);
}
if (priv->modified_handler_id) {
g_signal_handler_disconnect (priv->document, priv->modified_handler_id);
priv->modified_handler_id = 0;
}
if (ev_window_check_document_modified (ev_window, EV_WINDOW_ACTION_CLOSE))
return FALSE;