office/evince
office/evince
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/evince synced 2024-07-07 19:39:49 +00:00
Code Issues Projects Releases Wiki Activity

Fix omission from the GtkVBox to GtkBox conversion

Browse Source 
Commits 7d6a5f17c and bd9f1a6ad (2013-06-09) that changed the users of
GtkVbox to GtkBox neglected to change the type names in the instance and
class structures (it changed only the GObject type IDs).

Maybe this wasn't noticed before because GtkVBox is in fact derived from
GtkBox, which means that when the GObject machinery accessed the
structure it simply used the smaller prefix memory area corresponding to
a GtkBox.  So this bug may have been inconsequential, but it does
illustrate the amount of trust (read "burden") that GObject places on
the programmer by casting types all over the place (not that it can do
much better while staying in C).

https://bugzilla.gnome.org/show_bug.cgi?id=785783
This commit is contained in:
astian 2017-08-03 14:27:45 +00:00 committed by Carlos Garcia Campos
parent 75f8ea0f20
commit 73fedee31f
10 changed files with 20 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
properties/ev-properties-view.c
View File

@ -76,7 +76,7 @@ static const PropertyInfo properties_info[] = {
};
struct _EvPropertiesView {
GtkVBox base_instance;
GtkBox base_instance;
GtkWidget *grid;
GtkWidget *labels[N_PROPERTIES];
@ -85,7 +85,7 @@ struct _EvPropertiesView {
};
struct _EvPropertiesViewClass {
GtkVBoxClass base_class;
GtkBoxClass base_class;
};
G_DEFINE_TYPE (EvPropertiesView, ev_properties_view, GTK_TYPE_BOX)

4
shell/ev-properties-fonts.c
View File

@ -31,7 +31,7 @@
#include "ev-properties-fonts.h"
struct _EvPropertiesFonts {
GtkVBox base_instance;
GtkBox base_instance;
GtkWidget *fonts_treeview;
GtkWidget *fonts_progress_label;
@ -42,7 +42,7 @@ struct _EvPropertiesFonts {
};
struct _EvPropertiesFontsClass {
GtkVBoxClass base_class;
GtkBoxClass base_class;
};
static void

4
shell/ev-properties-license.c
View File

@ -29,11 +29,11 @@
#include "ev-properties-license.h"
struct _EvPropertiesLicense {
GtkVBox base_instance;
GtkBox base_instance;
};
struct _EvPropertiesLicenseClass {
GtkVBoxClass base_class;
GtkBoxClass base_class;
};
G_DEFINE_TYPE (EvPropertiesLicense, ev_properties_license, GTK_TYPE_BOX)

4
shell/ev-sidebar-annotations.h
View File

@ -38,13 +38,13 @@ typedef struct _EvSidebarAnnotationsPrivate EvSidebarAnnotationsPrivate;
#define EV_SIDEBAR_ANNOTATIONS_GET_CLASS(object) (G_TYPE_INSTANCE_GET_CLASS((object), EV_TYPE_SIDEBAR_ANNOTATIONS, EvSidebarAnnotationsClass))
struct _EvSidebarAnnotations {
GtkVBox base_instance;
GtkBox base_instance;
EvSidebarAnnotationsPrivate *priv;
};
struct _EvSidebarAnnotationsClass {
GtkVBoxClass base_class;
GtkBoxClass base_class;
void (* annot_activated) (EvSidebarAnnotations *sidebar_annots,
EvMapping *mapping);

4
shell/ev-sidebar-attachments.h
View File

@ -41,13 +41,13 @@ typedef struct _EvSidebarAttachmentsPrivate EvSidebarAttachmentsPrivate;
#define EV_SIDEBAR_ATTACHMENTS_GET_CLASS(object) (G_TYPE_INSTANCE_GET_CLASS((object), EV_TYPE_SIDEBAR_ATTACHMENTS, EvSidebarAttachmentsClass))
struct _EvSidebarAttachments {
GtkVBox base_instance;
GtkBox base_instance;
EvSidebarAttachmentsPrivate *priv;
};
struct _EvSidebarAttachmentsClass {
GtkVBoxClass base_class;
GtkBoxClass base_class;
/* Signals */
void (*popup_menu) (EvSidebarAttachments *ev_attachbar,

4
shell/ev-sidebar-bookmarks.h
View File

@ -40,13 +40,13 @@ typedef struct _EvSidebarBookmarksPrivate EvSidebarBookmarksPrivate;
#define EV_SIDEBAR_BOOKMARKS_GET_CLASS(object) (G_TYPE_INSTANCE_GET_CLASS((object), EV_TYPE_SIDEBAR_BOOKMARKS, EvSidebarBookmarksClass))
struct _EvSidebarBookmarks {
GtkVBox base_instance;
GtkBox base_instance;
EvSidebarBookmarksPrivate *priv;
};
struct _EvSidebarBookmarksClass {
GtkVBoxClass base_class;
GtkBoxClass base_class;
void (*add_bookmark) (EvSidebarBookmarks *sidebar_bookmarks);
};

4
shell/ev-sidebar-layers.h
View File

@ -38,13 +38,13 @@ typedef struct _EvSidebarLayersPrivate EvSidebarLayersPrivate;
#define EV_SIDEBAR_LAYERS_GET_CLASS(object) (G_TYPE_INSTANCE_GET_CLASS((object), EV_TYPE_SIDEBAR_LAYERS, EvSidebarLayersClass))
struct _EvSidebarLayers {
GtkVBox base_instance;
GtkBox base_instance;
EvSidebarLayersPrivate *priv;
};
struct _EvSidebarLayersClass {
GtkVBoxClass base_class;
GtkBoxClass base_class;
/* Signals */
void (* layers_visibility_changed) (EvSidebarLayers *ev_layers);

4
shell/ev-sidebar-links.h
View File

@ -44,13 +44,13 @@ typedef struct _EvSidebarLinksPrivate EvSidebarLinksPrivate;
#define EV_SIDEBAR_LINKS_GET_CLASS(object) (G_TYPE_INSTANCE_GET_CLASS((object), EV_TYPE_SIDEBAR_LINKS, EvSidebarLinksClass))
struct _EvSidebarLinks {
GtkVBox base_instance;
GtkBox base_instance;
EvSidebarLinksPrivate *priv;
};
struct _EvSidebarLinksClass {
GtkVBoxClass base_class;
GtkBoxClass base_class;
void (* link_activated) (EvSidebarLinks *sidebar_links,
EvLink *link);

4
shell/ev-sidebar-thumbnails.h
View File

@ -40,13 +40,13 @@ typedef struct _EvSidebarThumbnailsPrivate EvSidebarThumbnailsPrivate;
#define EV_SIDEBAR_THUMBNAILS_GET_CLASS(object) (G_TYPE_INSTANCE_GET_CLASS((object), EV_TYPE_SIDEBAR_THUMBNAILS, EvSidebarThumbnailsClass))
struct _EvSidebarThumbnails {
GtkVBox base_instance;
GtkBox base_instance;
EvSidebarThumbnailsPrivate *priv;
};
struct _EvSidebarThumbnailsClass {
GtkVBoxClass base_class;
GtkBoxClass base_class;
};
GType ev_sidebar_thumbnails_get_type (void) G_GNUC_CONST;

4
shell/ev-sidebar.h
View File

@ -42,13 +42,13 @@ typedef struct _EvSidebarPrivate EvSidebarPrivate;
#define EV_SIDEBAR_GET_CLASS(object) (G_TYPE_INSTANCE_GET_CLASS((object), EV_TYPE_SIDEBAR, EvSidebarClass))
struct _EvSidebar {
GtkVBox base_instance;
GtkBox base_instance;
EvSidebarPrivate *priv;
};
struct _EvSidebarClass {
GtkVBoxClass base_class;
GtkBoxClass base_class;
};
GType ev_sidebar_get_type (void) G_GNUC_CONST;